Skip to content

fix(aqua): support cosign v3 bundle verification#7314

Merged
jdx merged 1 commit intomainfrom
fix/cosign-v3-bundle
Dec 15, 2025
Merged

fix(aqua): support cosign v3 bundle verification#7314
jdx merged 1 commit intomainfrom
fix/cosign-v3-bundle

Conversation

@jdx
Copy link
Copy Markdown
Owner

@jdx jdx commented Dec 15, 2025

Summary

  • Updates sigstore-verification to 0.1.8 which adds support for cosign v3 message signature bundles
  • Cosign v3 changed from using DSSE envelopes to messageSignature for direct blob signing
  • This fixes installation of aqua:sigstore/cosign@3.0.2 and other packages using the new v3 bundle format

Fixes #6655

Changes in sigstore-verification 0.1.8

  • Added MessageSignature and MessageDigest types for parsing v3 bundles
  • Made dsse_envelope optional in SigstoreBundle struct
  • Updated bundle.rs to handle messageSignature bundles
  • Updated file.rs to parse v0.3 bundles with messageSignature
  • Updated cosign verifier to verify message signatures

Test plan

  • mise install aqua:sigstore/cosign@3.0.2 - succeeds
  • mise install aqua:sigstore/cosign@2.6.1 - still works
  • mise run test:e2e test_aqua_cosign - passes

🤖 Generated with Claude Code


Note

Bumps sigstore-verification to 0.1.8 and relaxes vfox's dependency to the 0.1 range.

  • Dependencies:
    • Upgrade sigstore-verification to 0.1.8 in Cargo.lock.
    • Relax crates/vfox/Cargo.toml dependency on sigstore-verification from "0.1.7" to "0.1".

Written by Cursor Bugbot for commit 744770b. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings December 15, 2025 13:02
Update sigstore-verification to 0.1.8 which adds support for cosign v3
message signature bundles. Cosign v3 changed from using DSSE envelopes
to messageSignature for direct blob signing.

Fixes #6655

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@jdx jdx force-pushed the fix/cosign-v3-bundle branch from 7e489dd to 744770b Compare December 15, 2025 13:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the sigstore-verification dependency from version 0.1.7 to 0.1.8 to add support for cosign v3 bundle verification. Cosign v3 introduced a breaking change by switching from DSSE envelopes to messageSignature for direct blob signing, which was causing installation failures for packages using the new v3 bundle format.

  • Updated sigstore-verification dependency to version 0.1.8 in both workspace and vfox crate
  • Enables installation of cosign v3 packages (e.g., aqua:sigstore/cosign@3.0.2)
  • Maintains backward compatibility with cosign v2 packages

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
crates/vfox/Cargo.toml Updates sigstore-verification dependency to 0.1.8
Cargo.toml Updates workspace-level sigstore-verification dependency to 0.1.8

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.12.7 x -- echo 20.9 ± 0.5 19.8 23.2 1.03 ± 0.04
mise x -- echo 20.4 ± 0.6 19.2 24.6 1.00

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.12.7 env 20.3 ± 0.7 19.3 27.1 1.02 ± 0.05
mise env 19.9 ± 0.6 18.6 21.3 1.00

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.12.7 hook-env 20.4 ± 0.6 19.4 27.9 1.02 ± 0.05
mise hook-env 20.1 ± 0.6 18.8 22.3 1.00

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2025.12.7 ls 17.3 ± 0.4 16.3 18.9 1.00
mise ls 17.7 ± 0.7 16.5 26.8 1.03 ± 0.05

xtasks/test/perf

Command mise-2025.12.7 mise Variance
install (cached) 109ms 110ms +0%
ls (cached) 65ms 66ms -1%
bin-paths (cached) 72ms 72ms +0%
task-ls (cached) 438ms ⚠️ 2260ms -80%

⚠️ Warning: task-ls cached performance variance is -80%

@jdx jdx merged commit 77737da into main Dec 15, 2025
29 checks passed
@jdx jdx deleted the fix/cosign-v3-bundle branch December 15, 2025 13:27
jdx pushed a commit that referenced this pull request Dec 15, 2025
### 🚀 Features

- **(conda)** add dependency resolution for conda packages by @jdx in
[#7280](#7280)
- **(go)** add created_at support to ls-remote --json by @jdx in
[#7305](#7305)
- **(hook-env)** add hook_env.cache_ttl and hook_env.chpwd_only settings
for NFS optimization by @jdx in
[#7312](#7312)
- **(hooks)** add MISE_TOOL_NAME and MISE_TOOL_VERSION to
preinstall/postinstall hooks by @jdx in
[#7311](#7311)
- **(shell_alias)** add shell_alias support for cross-shell aliases by
@jdx in [#7316](#7316)
- **(tool)** add security field to mise tool --json by @jdx in
[#7303](#7303)
- add --before flag for date-based version filtering by @jdx in
[#7298](#7298)

### 🐛 Bug Fixes

- **(aqua)** support cosign v3 bundle verification by @jdx in
[#7314](#7314)
- **(config)** use correct config_root in tera context for hooks by @jdx
in [#7309](#7309)
- **(nu)** fix nushell deactivation script on Windows by @fu050409 in
[#7213](#7213)
- **(python)** apply uv_venv_create_args in auto-venv code path by @jdx
in [#7310](#7310)
- **(shell)** escape exe path in activation scripts for paths with
spaces by @jdx in [#7315](#7315)
- **(task)** parallelize exec_env loading to fix parallel task execution
by @jdx in [#7313](#7313)
- track downloads for python and java by @jdx in
[#7304](#7304)
- include full tool ID in download track by @jdx in
[#7320](#7320)

### 📚 Documentation

- Switch `postinstall` code to be shell-agnostic by @thejcannon in
[#7317](#7317)

### 🧪 Testing

- **(e2e)** disable debug mode by default for windows-e2e by @jdx in
[#7318](#7318)

### New Contributors

- @fu050409 made their first contribution in
[#7213](#7213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants