feat(tasks): modify usage spec parsing to return dummy strings#6723
Merged
feat(tasks): modify usage spec parsing to return dummy strings#6723
Conversation
- Updated return values in the task script parser to return empty strings instead of null to prevent type errors. - Overrode the "throw" function to no-op to ignore errors. Fixes jdx#6646
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the task script parser to return empty strings instead of null values and disables error throwing during usage specification parsing. These changes prevent type errors when the parser processes template functions for collecting argument and flag specifications.
Key Changes:
- Registers a no-op
throwfunction that returns null instead of raising errors - Replaces
tera::Value::Nullreturn values with empty strings inarg,flag, andoptiontemplate functions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
Why is e2e-linux CI getting skipped? |
Owner
|
that's just release tests |
jdx
pushed a commit
that referenced
this pull request
Oct 23, 2025
### 🚀 Features - **(tasks)** modify usage spec parsing to return dummy strings by @iamkroot in [#6723](#6723) - include resolved sources in task templating context by @the-wondersmith in [#6180](#6180) - Add Tera function `absolute` by @iamkroot in [#6729](#6729) ### 🐛 Bug Fixes - **(cli)** respect os filter during upgrade by @iamkroot in [#6724](#6724) ### 📚 Documentation - fix RUNTIME.osType values in example snippet by @ofalvai in [#6732](#6732) - migrate issue links to GitHub discussions by @jdx in [#6740](#6740) - document Lua version by @ofalvai in [#6741](#6741) ### New Contributors - @ofalvai made their first contribution in [#6741](#6741) - @iamkroot made their first contribution in [#6729](#6729) - @the-wondersmith made their first contribution in [#6180](#6180) ## 📦 Aqua Registry Updates #### New Packages (8) - [`SUPERCILEX/fuc/cpz`](https://github.com/SUPERCILEX/fuc/cpz) - [`SUPERCILEX/fuc/rmz`](https://github.com/SUPERCILEX/fuc/rmz) - [`dinoDanic/diny`](https://github.com/dinoDanic/diny) - [`eth-p/bat-extras`](https://github.com/eth-p/bat-extras) - [`k1LoW/tailor-log`](https://github.com/k1LoW/tailor-log) - [`mashiike/acrun`](https://github.com/mashiike/acrun) - [`opengrep/opengrep`](https://github.com/opengrep/opengrep) - [`praetorian-inc/noseyparker`](https://github.com/praetorian-inc/noseyparker) #### Updated Packages (2) - [`bufbuild/buf`](https://github.com/bufbuild/buf) - [`bytecodealliance/wasm-tools`](https://github.com/bytecodealliance/wasm-tools)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated return values in the task script parser to return empty
strings instead of null to prevent type errors.
Overrode the "throw" function to no-op to ignore errors.
Fixes #6646