fix(task): use config_root instead of project_root for task base path#6609
Merged
fix(task): use config_root instead of project_root for task base path#6609
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes task loading to use the correct base path by switching from project_root() to config_root() when resolving task paths.
- Replaced
project_rootwithconfig_rootvariable - Updated function calls to pass
config_rootinstead ofproject_root - Removed fallback to
env::HOMEwhen project root is unavailable
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Owner
|
bugbot run |
jdx
pushed a commit
that referenced
this pull request
Oct 10, 2025
### 📦 Registry - add lazyssh by @TyceHerrman in [#6610](#6610) ### 🚀 Features - **(config)** Add a ceiling to how mise searchs for config & tasks by @richardthe3rd in [#6041](#6041) ### 🐛 Bug Fixes - **(task)** use config_root instead of project_root for task base path by @risu729 in [#6609](#6609) - **(task)** resolve project tasks in run blocks using TaskLoadContext by @jdx in [#6614](#6614) - **(task)** dont truncate task message when CI is set by @roele in [#6620](#6620) - **(ui)** prevent OSC 9;4 progress sequences from being written to non-terminals by @jdx in [#6615](#6615) ### Chore - remove cosign/slsa-verifier from mise.toml by @jdx in [#6616](#6616) ### New Contributors - @richardthe3rd made their first contribution in [#6041](#6041)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5987.
We currently resolve
task_config.includesrelative to theproject_root, but global configs don't haveproject_rootandenv::HOMEis used as a fallback.This PR fixes the root of
task_config.includestoconfig_root, which isMISE_GLOBAL_CONFIG_ROOTfor global tasks.This might be confusing for system configs like
/etc/mise/config.toml, but I think the consistency with local config files should be prioritised here.task_config.diris also joined withconfig_root.Note
Switch task base path resolution to use
config_rootfor both config-defined and file-discovered tasks.cf.config_root()as the base path when loading tasks (load_config_tasks,load_file_tasks).project_rootwithenv::HOMEfallback.Written by Cursor Bugbot for commit a6fe174. This will update automatically on new commits. Configure here.