fix(vfox): integrate parse_legacy_file into backend#6471
Merged
Conversation
Owner
|
bugbot run |
jdx
added a commit
that referenced
this pull request
Sep 29, 2025
### 📦 Registry - add ggshield by @TyceHerrman in [#6435](#6435) - add jaq by @TyceHerrman in [#6434](#6434) ### 🚀 Features - **(age)** support age encrypted env vars in mise.toml files by @jdx in [#6463](#6463) ### 🐛 Bug Fixes - **(vfox)** integrate `parse_legacy_file` into backend by @malept in [#6471](#6471) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps to 2025.9.24 with age‑encrypted env var support, registry additions (ggshield, jaq, patterner), vfox fix, and lockfile/tooling updates. > > - **Release** > - Bump version to `2025.9.24` across `Cargo.toml`, `Cargo.lock`, `default.nix`, `packaging/rpm/mise.spec`, `README.md`, and shell completions; update `CHANGELOG.md`. > - **Features** > - Support age‑encrypted env vars in `mise.toml`. > - **Registry** > - Add `ggshield`, `jaq` entries; add `tailor-platform/patterner` in `crates/aqua-registry/.../patterner/registry.yaml`. > - **Bug Fixes** > - `(vfox)` integrate `parse_legacy_file` into backend. > - **Dependencies/Tooling** > - Update `mise.lock`: `usage-cli` → 2.3.2, `hk` → 1.15.7, `sops` → 3.11.0. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0b0708b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: mise-en-dev <release@mise.jdx.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using a custom tool plugin, the
ParseLegacyFilehook is not called when an idiomatic version file is used.Steps to reproduce
Assumes that you're using a tool plugin written based off of the docs, where
.foo-versionis declared as inmetadata.lua, as is theParseLegacyFilelua hook.mise.toml:.foo-version:Run:
foo@1.2.3is installedfoois not installedSolution
Use the
vfoxcrate'sparse_legacy_filefunctionality in theVfoxBackend. The crate's functionality is async, so the corresponding functions in theBackendtrait and its implementations needed to change to be async as well.Note
Integrates vfox
parse_legacy_filefor idiomatic version files and converts idiomatic filename parsing to async across backends, config, and CLI.Backendmethods async:idiomatic_filenames()andparse_idiomatic_file().node,python,ruby,go,java,rust,swift,deno,bun,zig) andasdf.VfoxBackendnow fetches idiomatic filenames from vfox metadata and parses versions via vfoxparse_legacy_file.ctx.filenameto Lua context; dummy hook validates.dummy-versionand usesfile.read.config_file::parse/parse_or_init, idiomatic detection, andIdiomaticVersionFileparsing are async; cascade updates touse,local,unuse,upgrade,prune,lock, andconfig generate.filename_is_idiomatic, async tests); adjust loops and error handling accordingly.Written by Cursor Bugbot for commit 4094cf0. This will update automatically on new commits. Configure here.