fix(uv): avoid deadlocks while initializing UV_VENV#4609
Merged
Conversation
jdx
requested changes
Mar 11, 2025
Contributor
Author
|
I'm sorry for my mistake. I assumed my fix worked, but it actually does not. This PR does not resolve the deadlock. I misunderstood the root cause, a deadlock occurring during initialization, so using I will continue working on this. |
Owner
|
is it because you need cross-process locking? if so, have a look at https://github.com/jdx/mise/blob/main/src/lock_file.rs |
risu729
added a commit
to risu729/mise
that referenced
this pull request
Mar 26, 2025
This reverts commit 26d203a.
risu729
added a commit
to risu729/mise
that referenced
this pull request
Apr 20, 2025
This reverts commit 26d203a.
risu729
added a commit
to risu729/mise
that referenced
this pull request
Apr 20, 2025
This reverts commit 26d203a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4600.
UV_VENVinitialization somtimes cause a deadlock in some cases because it requires loadingpathorenvto get the toolset.This PR avoids the deadlock by using
Mutexand returningNonewhile initializing itself.