feat(builtins): add `buildifier` format and lint built-ins by plx · Pull Request #896 · jdx/hk

plx · 2026-04-30T21:15:20Z

I added support for buildifier, which is a tool for formatting and linting starlark (e.g. Bazel's BUILD files, .bzl files, and so on).

I modeled the two new additions on buf, which is also present as buf_format and buf_lint.

I ran hk fix --all before opening the PR, and have made some exploratory usage of these new built-ins as part of evaluating hk adoption for a large bazel project.

Appreciate your attention (and hk!), and am happy to make any adjustments you need.

Add buildifier as two built-in linters for Bazel/Starlark files: - buildifier_format: formatting check/fix using -mode=check - buildifier_lint: lint warnings + formatting using -lint=warn/-lint=fix Covers BUILD, BUILD.bazel, WORKSPACE, WORKSPACE.bazel, MODULE.bazel, *.bzl, *.star, and *.sky files.

gemini-code-assist

Code Review

This pull request introduces built-in formatting and linting steps for Bazel using the buildifier tool, along with a corresponding tool stub. The review feedback identifies a logical error in the linting test case, which incorrectly expects buildifier to resolve missing load statements. Additionally, the reviewer suggests expanding the file glob patterns to include more Bazel-specific extensions and subdirectories, adding check_diff commands for better efficiency, and correcting a version typo in the tool stub.

gemini-code-assist · 2026-04-30T21:16:56Z

+    local const before =
+      """
+      cc_library(
+          name = "foo",
+          srcs = ["Foo.cc"],
+      )
+
+      """
+    local const after =
+      """
+      load("@rules_cc//cc:cc_library.bzl", "cc_library")
+
+      cc_library(
+          name = "foo",
+          srcs = ["Foo.cc"],
+      )
+
+      """


This test case expects buildifier -lint=fix to automatically add a missing load statement. However, buildifier is a formatter and linter; it does not have the capability to resolve and add missing dependencies (that is typically handled by tools like gazelle). This test will likely fail as the fix command won't produce the expected after content.

Consider using a fixable lint issue such as out-of-order-load or unsorted-dict-items for this test.

What's actually going on here is that:

bazel has traditionally had built-in rules for C-family languages

as built-ins, these did not need to be loaded—they were just "always there"

recent bazel versions have migrated these built-in rules to external rules (that must then be loaded)

the built-ins are maintained for backwards-compatibility, but the external, loadable rules are preferred

there's a rule in buildifer that spots use of the legacy built-ins and adds any necessary load statements

Or, tl;dr: this test example looks like a (nonexistant) generic automatic-import-finder thing, but is just a narrow-purpose rule targeting a list of known rules.

gemini-code-assist · 2026-04-30T21:16:56Z

+  glob = List(
+    "**/BUILD",
+    "**/BUILD.bazel",
+    "WORKSPACE",
+    "WORKSPACE.bazel",
+    "MODULE.bazel",
+    "**/*.bzl",
+    "**/*.star",
+    "**/*.sky"
+  )


The glob list is missing some common Bazel/Starlark file patterns and some entries are restricted to the root directory. It is better to include **/WORKSPACE, **/MODULE.bazel, **/REPO.bazel, and **/*.BUILD to ensure all relevant files are covered regardless of their location in the repository.

glob = List( "**/BUILD", "**/BUILD.bazel", "**/WORKSPACE", "**/WORKSPACE.bazel", "**/MODULE.bazel", "**/REPO.bazel", "**/*.bzl", "**/*.star", "**/*.sky", "**/*.BUILD" )

This and the other similar comment are a good idea—will expand the list.

gemini-code-assist · 2026-04-30T21:16:56Z

+    "**/*.star",
+    "**/*.sky"
+  )
+  check = "buildifier -mode=check {{ files }}"


Adding check_diff allows hk to use git apply for applying formatting changes. This is generally more efficient and safer than running the full fix command when only formatting changes are needed.

check = "buildifier -mode=check {{ files }}" check_diff = "buildifier -mode=diff {{ files }}"

This and the other similar comment are a good idea—will investigate and update.

gemini-code-assist · 2026-04-30T21:16:56Z

+  glob = List(
+    "**/BUILD",
+    "**/BUILD.bazel",
+    "WORKSPACE",
+    "WORKSPACE.bazel",
+    "MODULE.bazel",
+    "**/*.bzl",
+    "**/*.star",
+    "**/*.sky"
+  )


The glob list should be expanded to include all relevant Bazel and Starlark files, matching the improvements suggested for the formatter builtin.

glob = List( "**/BUILD", "**/BUILD.bazel", "**/WORKSPACE", "**/WORKSPACE.bazel", "**/MODULE.bazel", "**/REPO.bazel", "**/*.bzl", "**/*.star", "**/*.sky", "**/*.BUILD" )

gemini-code-assist · 2026-04-30T21:16:56Z

+    "**/*.star",
+    "**/*.sky"
+  )
+  check = "buildifier -mode=check -lint=warn {{ files }}"


Adding check_diff with -lint=warn allows hk to apply both formatting and lint fixes via patches, which is more efficient than running the fix command.

check = "buildifier -mode=check -lint=warn {{ files }}" check_diff = "buildifier -mode=diff -lint=warn {{ files }}"

gemini-code-assist · 2026-04-30T21:16:56Z

@@ -0,0 +1,4 @@
+#!/usr/bin/env -S mise tool-stub
+
+version = "8.5.1"


The version 8.5.1 appears to be a typo. The current latest stable version of buildifier (from the bazelbuild/buildtools repository) is 8.0.1. Using a non-existent version will cause installation failures in tool managers like mise.

version = "8.0.1"

I suspect this is an LLM hallucination because I can literally verify that there's an 8.5.1 version of buildifier available here.

greptile-apps · 2026-04-30T21:18:57Z

Greptile Summary

This PR adds buildifier_format and buildifier_lint built-ins for formatting and linting Starlark/Bazel files, modeled after the existing buf_format/buf_lint pattern. Commands, exit codes, glob patterns, and test fixtures are all consistent with buildifier's documented behavior (exit 4 for both formatting needs and lint warnings in -lint=warn mode).

Confidence Score: 5/5

Safe to merge — no logic errors or behavioral bugs found.

All commands match buildifier's documented interface, exit codes in tests are correct (4 for both formatting and lint issues in warn mode), and the implementation cleanly mirrors the established buf_format/buf_lint pattern.

No files require special attention.

Important Files Changed

Filename	Overview
pkl/builtins/buildifier_format.pkl	New format step for buildifier: correctly uses -mode=check for check and bare buildifier for fix, exit code 4 in tests matches buildifier's documented "needs reformatting" signal.
pkl/builtins/buildifier_lint.pkl	New lint step for buildifier: uses -mode=check -lint=warn for check and -lint=fix for fix; exit code 4 is correct per buildifier docs (lint warnings in warn mode also trigger exit 4).
test/builtin_tool_stubs/buildifier	Standard mise tool-stub for buildifier tests, pinned to version 8.5.1; consistent with other stubs in the directory.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Changed Starlark files\n BUILD / .bzl / .star etc.] --> B{Step type}
    B -->|buildifier_format check| C["buildifier -mode=check {{ files }}"]
    B -->|buildifier_format fix| D["buildifier {{ files }}"]
    B -->|buildifier_lint check| E["buildifier -mode=check -lint=warn {{ files }}"]
    B -->|buildifier_lint fix| F["buildifier -lint=fix {{ files }}"]
    C -->|exit 0| G[Files already formatted ✓]
    C -->|exit 4| H[Formatting needed ✗]
    D -->|exit 0| I[Files reformatted ✓]
    E -->|exit 0| J[No format or lint issues ✓]
    E -->|exit 4| K[Format or lint issues ✗]
    F -->|exit 0| L[Lint issues fixed ✓]

_{Reviews (2): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}

@plx

### 🚀 Features - **(builtins)** add `buildifier` format and lint built-ins by [@plx](https://github.com/plx) in [#896](#896) ### 🐛 Bug Fixes - **(step)** only auto-batch when rendered command exceeds ARG_MAX by [@jdx](https://github.com/jdx) in [#901](#901) ### 📚 Documentation - thank Namespace for GitHub Actions runner support by [@jdx](https://github.com/jdx) in [#895](#895) ### 🔍 Other Changes - **(ci)** use !cancelled() instead of always() for final job by [@jdx](https://github.com/jdx) in [#906](#906) - **(docs)** remove shrill.en.dev analytics script by [@jdx](https://github.com/jdx) in [#903](#903) - remove rust-cache from release jobs by [@jdx](https://github.com/jdx) in [#893](#893) - invert CLAUDE.md/AGENTS.md so AGENTS.md is canonical by [@jdx](https://github.com/jdx) in [#905](#905) - set dev profile debug to 1 by [@jdx](https://github.com/jdx) in [#907](#907) ### 📦️ Dependency Updates - update anthropics/claude-code-action digest to fefa07e by [@renovate[bot]](https://github.com/renovate[bot]) in [#897](#897) - update jdx/mise-action digest to 1648a78 by [@renovate[bot]](https://github.com/renovate[bot]) in [#898](#898) - update apple-actions/import-codesign-certs action to v7 by [@renovate[bot]](https://github.com/renovate[bot]) in [#900](#900) - update autofix-ci/action action to v1.3.4 by [@renovate[bot]](https://github.com/renovate[bot]) in [#899](#899) - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#908](#908) ### New Contributors - @plx made their first contribution in [#896](#896)  --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: primarily version string updates across manifests and docs with no functional code changes in this diff. > > **Overview** > Updates the project for the `v1.45.0` release by bumping the crate/CLI version (`Cargo.toml`, `Cargo.lock`, `hk.usage.kdl`, generated CLI docs) and adding the `1.45.0` entry to `CHANGELOG.md`. > > Refreshes documentation and example configs to reference the new versioned Pkl package URLs (`docs/*.md`, `docs/public/*.pkl`, `hk-example.pkl`). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit cfe2da5. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>  Co-authored-by: mise-en-dev <123107610+mise-en-dev@users.noreply.github.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.43.0` → `1.45.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.45.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1450---2026-05-04) [Compare Source](jdx/hk@v1.44.3...v1.45.0) ##### 🚀 Features - **(builtins)** add `buildifier` format and lint built-ins by [@plx](https://github.com/plx) in [#896](jdx/hk#896) ##### 🐛 Bug Fixes - **(step)** only auto-batch when rendered command exceeds ARG\_MAX by [@jdx](https://github.com/jdx) in [#901](jdx/hk#901) ##### 📚 Documentation - thank Namespace for GitHub Actions runner support by [@jdx](https://github.com/jdx) in [#895](jdx/hk#895) ##### 🔍 Other Changes - **(ci)** use !cancelled() instead of always() for final job by [@jdx](https://github.com/jdx) in [#906](jdx/hk#906) - **(docs)** remove shrill.en.dev analytics script by [@jdx](https://github.com/jdx) in [#903](jdx/hk#903) - remove rust-cache from release jobs by [@jdx](https://github.com/jdx) in [#893](jdx/hk#893) - invert CLAUDE.md/AGENTS.md so AGENTS.md is canonical by [@jdx](https://github.com/jdx) in [#905](jdx/hk#905) - set dev profile debug to 1 by [@jdx](https://github.com/jdx) in [#907](jdx/hk#907) ##### 📦️ Dependency Updates - update anthropics/claude-code-action digest to [`fefa07e`](jdx/hk@fefa07e) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#897](jdx/hk#897) - update jdx/mise-action digest to [`1648a78`](jdx/hk@1648a78) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#898](jdx/hk#898) - update apple-actions/import-codesign-certs action to v7 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#900](jdx/hk#900) - update autofix-ci/action action to v1.3.4 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#899](jdx/hk#899) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#908](jdx/hk#908) ##### New Contributors - [@plx](https://github.com/plx) made their first contribution in [#896](jdx/hk#896) ### [`v1.44.3`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1443---2026-04-30) [Compare Source](jdx/hk@v1.44.2...v1.44.3) ##### 🐛 Bug Fixes - **(hook)** do not stage fixes when fail\_on\_fix=true by [@jdx](https://github.com/jdx) in [#892](jdx/hk#892) - use site domain for plausible data-domain by [@jdx](https://github.com/jdx) in [#886](jdx/hk#886) - make text-mode progress output usable in CI by [@jdx](https://github.com/jdx) in [#890](jdx/hk#890) ##### 📚 Documentation - prefix GitHub star count with ★ glyph by [@jdx](https://github.com/jdx) in [#883](jdx/hk#883) ##### 🔍 Other Changes - **(release)** dedupe sponsor section in release notes by [@jdx](https://github.com/jdx) in [#881](jdx/hk#881) - switch analytics from gtm/goatcounter to plausible by [@jdx](https://github.com/jdx) in [#885](jdx/hk#885) - migrate to namespace.so runners by [@jdx](https://github.com/jdx) in [#891](jdx/hk#891) ### [`v1.44.2`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1442---2026-04-26) [Compare Source](jdx/hk@v1.44.1...v1.44.2) ##### 🐛 Bug Fixes - **(builtins)** silence pklr deprecation warnings on Builtins.pkl load by [@jdx](https://github.com/jdx) in [#880](jdx/hk#880) - **(ci)** serialize docs lint step by [@jdx](https://github.com/jdx) in [#874](jdx/hk#874) - **(config)** include main pkl path in cache fresh files by [@jdx](https://github.com/jdx) in [#879](jdx/hk#879) - **(docs)** stack banner message and link on mobile by [@jdx](https://github.com/jdx) in [#865](jdx/hk#865) - **(docs)** pin banner close button to top-right corner on mobile by [@jdx](https://github.com/jdx) in [#867](jdx/hk#867) ##### 📚 Documentation - **(site)** show release version and github stars by [@jdx](https://github.com/jdx) in [#872](jdx/hk#872) ##### 🔍 Other Changes - add pr-closer workflow by [@jdx](https://github.com/jdx) in [#876](jdx/hk#876) ##### 📦️ Dependency Updates - bump communique 1.0.3 → 1.0.4 by [@jdx](https://github.com/jdx) in [#868](jdx/hk#868) - update anthropics/claude-code-action digest to [`2da6cfa`](jdx/hk@2da6cfa) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#869](jdx/hk#869) - update anthropics/claude-code-action digest to [`567fe95`](jdx/hk@567fe95) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#870](jdx/hk#870) - bump communique to 1.1.2 by [@jdx](https://github.com/jdx) in [#875](jdx/hk#875) ### [`v1.44.1`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1441---2026-04-24) [Compare Source](jdx/hk@v1.44.0...v1.44.1) ##### 🐛 Bug Fixes - **(git)** skip untracked scan when HK\_STASH\_UNTRACKED=false by [@jdx](https://github.com/jdx) in [#861](jdx/hk#861) - **(run)** add post-commit and pre-rebase subcommands by [@jdx](https://github.com/jdx) in [#858](jdx/hk#858) ##### 📚 Documentation - **(install)** recommend global hooks as primary setup path by [@jdx](https://github.com/jdx) in [#855](jdx/hk#855) - add cross-site announcement banner by [@jdx](https://github.com/jdx) in [#857](jdx/hk#857) - respect banner expires field by [@jdx](https://github.com/jdx) in [#862](jdx/hk#862) ##### 🔍 Other Changes - vendor bats test helpers instead of git submodules by [@jdx](https://github.com/jdx) in [#859](jdx/hk#859) ##### 📦️ Dependency Updates - bump communique to 1.0.3 by [@jdx](https://github.com/jdx) in [#863](jdx/hk#863) - update anthropics/claude-code-action digest to [`e58dfa5`](jdx/hk@e58dfa5) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#864](jdx/hk#864) ### [`v1.44.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1440---2026-04-23) [Compare Source](jdx/hk@v1.43.0...v1.44.0) ##### 🚀 Features - **(check)** implement --plan, --why, and --json by [@jdx](https://github.com/jdx) in [#848](jdx/hk#848) - **(cocogitto)** add cocogitto conventional commits config to hk builtin config by [@hituzi-no-sippo](https://github.com/hituzi-no-sippo) in [#838](jdx/hk#838) - **(git)** support GIT\_DIR/GIT\_WORK\_TREE for bare-repo dotfile managers by [@jdx](https://github.com/jdx) in [#847](jdx/hk#847) - **(install)** use Git 2.54 config-based hooks with --global support by [@jdx](https://github.com/jdx) in [#853](jdx/hk#853) ##### 🐛 Bug Fixes - use text progress in CI by [@jdx](https://github.com/jdx) in [#845](jdx/hk#845) ##### 📚 Documentation - generalize agent guidelines by [@jdx](https://github.com/jdx) in [#846](jdx/hk#846) - add releases nav and aube lock by [@jdx](https://github.com/jdx) in [#849](jdx/hk#849) ##### 🔍 Other Changes - **(release)** append en.dev sponsor blurb to release notes by [@jdx](https://github.com/jdx) in [#854](jdx/hk#854) - bump communique to 1.0.1 by [@jdx](https://github.com/jdx) in [#850](jdx/hk#850) ##### 📦️ Dependency Updates - update actions-rust-lang/setup-rust-toolchain digest to [`2b1f5e9`](jdx/hk@2b1f5e9) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#832](jdx/hk#832) - update anthropics/claude-code-action digest to [`c3d45e8`](jdx/hk@c3d45e8) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#833](jdx/hk#833) - update rust crate tokio to v1.52.1 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#834](jdx/hk#834) - update actions/upload-pages-artifact action to v5 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#835](jdx/hk#835) - update taiki-e/upload-rust-binary-action digest to [`f0d45ae`](jdx/hk@f0d45ae) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#839](jdx/hk#839) - update rust crate clx to v2 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#836](jdx/hk#836) - update anthropics/claude-code-action digest to [`0d2971c`](jdx/hk@0d2971c) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#841](jdx/hk#841) - update anthropics/claude-code-action digest to [`38ec876`](jdx/hk@38ec876) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#842](jdx/hk#842) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#851](jdx/hk#851) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).

plx and others added 2 commits April 30, 2026 15:52

Merge branch 'main' into feat/add-buildifier-as-builtin-linter

6593b02

gemini-code-assist Bot reviewed Apr 30, 2026

View reviewed changes

greptile-apps Bot reviewed Apr 30, 2026

View reviewed changes

Comment thread pkl/builtins/buildifier_lint.pkl

[autofix.ci] apply automated fixes

12dba93

jdx merged commit d3a73e4 into jdx:main Apr 30, 2026
28 checks passed

jdx mentioned this pull request Apr 30, 2026

chore: release v1.45.0 #894

Merged

		@@ -0,0 +1,4 @@
		#!/usr/bin/env -S mise tool-stub

		version = "8.5.1"

Uh oh!

Conversation

plx commented Apr 30, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

plx Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

plx Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

plx Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

plx Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Apr 30, 2026 •

edited

Loading