fix(builtins): use workspace_indicator for Go package-level analysis tools by jdx · Pull Request #803 · jdx/hk

jdx · 2026-04-05T13:56:50Z

Summary

Switches 7 Go package-level analysis builtins (go_vet, golangci_lint, go_sec, go_vuln_check, staticcheck, revive, err_check) from {{ files }} to workspace_indicator = "go.mod" with ./...
Go tools using go/packages fail with "named files must all be in one directory" when files span multiple packages — this is a Go toolchain constraint, not a bug in any linter
File-level formatters (go_fmt, go_fumpt, go_imports, go_lines) are unchanged as they don't need package context
Adds bats integration tests verifying workspace_indicator behavior for Go builtins

Fixes #802

Test plan

Bats tests pass (libgit2 + nolibgit2 modes)
Manual test with multi-package Go project per reproduction steps in Go builtins using {{ files }} break with multi-package file lists #802

🤖 Generated with Claude Code

Note

Medium Risk
Changes how several Go builtins invoke analyzers by switching from file-list execution to module-wide ./... runs, which can alter coverage/performance and step results in monorepos. Adds new builtin test/tool-stub infrastructure, but the changes are contained to builtin definitions and test scaffolding.

Overview
Updates Go package-level builtin steps (go_vet, golangci_lint, go_sec, go_vuln_check, staticcheck, revive, err_check) to run from the detected Go module root via workspace_indicator = "go.mod" and execute against ./... instead of passing {{files}}.

Adds pkl-level tests for go_vet (including a multi-package case) and introduces mise tool stubs under test/builtin_tool_stubs/ for Go and several Go linters/scanners. Documentation in CLAUDE.md is expanded with guidance on writing/running builtin tests and using tool stubs.

^{Reviewed by Cursor Bugbot for commit aa8c16b. Bugbot is set up for automated code reviews on this repo. Configure here.}

…tools Go tools that use go/packages internally (go vet, golangci-lint, gosec, govulncheck, staticcheck, revive, errcheck) fail when {{ files }} expands to paths spanning multiple packages, because go list requires all named files to be in one directory. Switch these builtins to use workspace_indicator = "go.mod" with ./... instead of {{ files }}. File-level formatters (gofmt, gofumpt, goimports, golines) are unchanged as they operate on individual files without needing package context. Fixes #802 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

greptile-apps · 2026-04-05T14:00:07Z

Greptile Summary

Fixes the "named files must all be in one directory" error that occurs when Go package-level analysis tools receive files spanning multiple packages. Seven Go analysis builtins are switched from passing {{ files }} directly to each tool, to using workspace_indicator = "go.mod" and cd {{workspace}} && <tool> ./..., correctly operating at the module level. File-level formatters (go_fmt, go_fumpt, go_imports, go_lines) are intentionally left unchanged.

7 builtins updated (go_vet, golangci_lint, go_sec, go_vuln_check, staticcheck, revive, err_check): each now sets workspace_indicator = "go.mod" and runs cd {{workspace}} && <tool> ./...
Pkl-level tests added to go_vet covering a valid single-package file, an invalid file (unused import "fmt" triggers a compile error that go vet catches), and a multi-package workspace — these run via test/builtins_tests.bats
Five new tool stubs added in test/builtin_tool_stubs/ (go, golangci-lint, gosec, revive, staticcheck) to support on-demand tool installation during test runs
CLAUDE.md updated with a "Testing Builtins" section documenting the Pkl tests field, tool stubs, and the 4-step workflow for adding new builtins with tests

Confidence Score: 5/5

Safe to merge — all 7 builtins receive the same correct workspace-scoped fix with no logic errors or regressions

No P0 or P1 issues found. The root cause (Go toolchain rejecting multi-directory file lists) is well-understood and the fix is the canonical approach used across Go tooling. The only remaining gap is that 6 of 7 changed builtins lack Pkl-level tests, but this was already flagged in a prior review thread and does not affect the correctness of the changes.

No files require special attention; all changes are consistent and well-scoped

Important Files Changed

Filename	Overview
CLAUDE.md	Adds Testing Builtins documentation covering Pkl-level tests, tool stubs, and the workflow for new builtins
pkl/builtins/go_vet.pkl	Switches to workspace_indicator+./... and adds three Pkl-level tests (good file, bad file, multi-package)
pkl/builtins/golangci_lint.pkl	Switches both check and fix commands to workspace_indicator+./... pattern
pkl/builtins/go_sec.pkl	Switches gosec from per-file to workspace_indicator+./... pattern
pkl/builtins/go_vuln_check.pkl	Switches govulncheck from per-file to workspace_indicator+./... pattern
pkl/builtins/revive.pkl	Switches revive from per-file to workspace_indicator+./... pattern
pkl/builtins/staticcheck.pkl	Switches staticcheck from per-file to workspace_indicator+./... pattern
pkl/builtins/err_check.pkl	Switches errcheck from per-file to workspace_indicator+./... pattern
test/builtin_tool_stubs/go	New mise tool-stub pinning Go 1.25 for builtin test runs
test/builtin_tool_stubs/golangci-lint	New mise tool-stub for golangci-lint v2 via aqua:golangci/golangci-lint
test/builtin_tool_stubs/gosec	New mise tool-stub for gosec v2 via aqua:securego/gosec
test/builtin_tool_stubs/revive	New mise tool-stub for revive v1 via aqua:mgechev/revive
test/builtin_tool_stubs/staticcheck	New mise tool-stub for staticcheck 2025 release via aqua:dominikh/go-tools/staticcheck

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Go .go file staged] --> B{glob matches?}
    B -- No --> C[Step skipped]
    B -- Yes --> D{workspace_indicator
go.mod found?}
    D -- No --> C
    D -- Yes --> E[Resolve workspace dir]
    E --> F[cd workspace]
    F --> G[tool ./...]
    G --> H{Exit code}
    H -- 0 --> I[Step passes]
    H -- non-0 --> J[Step fails / reported]

_{Reviews (3): Last reviewed commit: "fix(builtins): add go tool stub for go_v..." | Re-trigger Greptile}

gemini-code-assist

Code Review

This pull request updates several Go-related builtin analysis tools to use workspace-based execution (cd {{workspace}} && ... ./...) instead of individual file lists, enabling support for multi-package projects and monorepos. A new test suite was added to verify these changes. The review feedback consistently recommends enclosing the {{workspace}} variable in double quotes across all modified files to ensure the commands remain robust when workspace paths contain spaces.

gemini-code-assist · 2026-04-05T14:02:05Z

  glob = "**/*.go"
-  check = "errcheck {{ files }}"
+  workspace_indicator = "go.mod"
+  check = "cd {{workspace}} && errcheck ./..."


The {{workspace}} variable should be enclosed in double quotes to ensure the command remains robust if the workspace path contains spaces. Since this command is executed via a shell, unquoted paths with spaces will cause the cd command to fail or behave unexpectedly.

check = "cd \"{{workspace}}\" && errcheck ./..."

gemini-code-assist · 2026-04-05T14:02:06Z

  glob = "**/*.go"
-  check = "gosec {{ files }}"
+  workspace_indicator = "go.mod"
+  check = "cd {{workspace}} && gosec ./..."


The {{workspace}} variable should be enclosed in double quotes to handle paths that contain spaces. Without quotes, the shell will split the path into multiple arguments, causing the cd command to fail.

check = "cd \"{{workspace}}\" && gosec ./..."

gemini-code-assist · 2026-04-05T14:02:06Z

  glob = "**/*.go"
-  check = "go vet {{ files }}"
+  workspace_indicator = "go.mod"
+  check = "cd {{workspace}} && go vet ./..."


Enclose {{workspace}} in double quotes to ensure the command works correctly in environments where directory names contain spaces.

check = "cd \"{{workspace}}\" && go vet ./..."

gemini-code-assist · 2026-04-05T14:02:06Z

  glob = "**/*.go"
-  check = "govulncheck {{ files }}"
+  workspace_indicator = "go.mod"
+  check = "cd {{workspace}} && govulncheck ./..."


The {{workspace}} variable should be quoted to prevent shell word-splitting issues when the path contains spaces.

check = "cd \"{{workspace}}\" && govulncheck ./..."

gemini-code-assist · 2026-04-05T14:02:06Z

+  check = "cd {{workspace}} && golangci-lint run --fix=false ./..."
+  fix = "cd {{workspace}} && golangci-lint run --fix ./..."


Both the check and fix commands should have {{workspace}} wrapped in double quotes to safely handle workspace paths containing spaces.

check = "cd \"{{workspace}}\" && golangci-lint run --fix=false ./..." fix = "cd \"{{workspace}}\" && golangci-lint run --fix ./..."

gemini-code-assist · 2026-04-05T14:02:06Z

  glob = "**/*.go"
-  check = "revive {{ files }}"
+  workspace_indicator = "go.mod"
+  check = "cd {{workspace}} && revive ./..."


Quote the {{workspace}} variable to ensure compatibility with paths that include spaces.

check = "cd \"{{workspace}}\" && revive ./..."

gemini-code-assist · 2026-04-05T14:02:06Z

  glob = "**/*.go"
-  check = "staticcheck {{ files }}"
+  workspace_indicator = "go.mod"
+  check = "cd {{workspace}} && staticcheck ./..."


The {{workspace}} variable should be quoted to handle directory names with spaces correctly in the shell.

check = "cd \"{{workspace}}\" && staticcheck ./..."

Replace bats integration test with proper pkl-level tests for go_vet that exercise the workspace_indicator + ./... pattern with real Go code. Add mise tool stubs for golangci-lint, staticcheck, revive, and gosec. Document builtin testing patterns in CLAUDE.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

The go_vet pkl tests need the `go` binary, which isn't available in all CI environments. Add a mise tool-stub for `go` so the builtins test harness can auto-install it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.40.0` → `1.41.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.41.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1410---2026-04-05) [Compare Source](jdx/hk@v1.40.0...v1.41.0) ##### 🚀 Features - **(hook)** support per-worktree hooks via extensions.worktreeConfig by [@nkakouros](https://github.com/nkakouros) in [#789](jdx/hk#789) ##### 🐛 Bug Fixes - **(builtins)** use workspace\_indicator for Go package-level analysis tools by [@jdx](https://github.com/jdx) in [#803](jdx/hk#803) - **(config)** use XDG\_CONFIG\_HOME for config path instead of dirs::config\_dir() by [@fukuchancat](https://github.com/fukuchancat) in [#801](jdx/hk#801) ##### 📦️ Dependency Updates - update anthropics/claude-code-action digest to [`0432df8`](jdx/hk@0432df8) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#791](jdx/hk#791) - update rust crate indexmap to v2.13.1 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#792](jdx/hk#792) - update actions/configure-pages action to v6 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#795](jdx/hk#795) - update rust crate strum to 0.28 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#794](jdx/hk#794) - update actions/deploy-pages action to v5 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#796](jdx/hk#796) - update dependency globals to v17 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#797](jdx/hk#797) - update github artifact actions (major) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#798](jdx/hk#798) - update jdx/mise-action action to v4 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#799](jdx/hk#799) ##### New Contributors - [@fukuchancat](https://github.com/fukuchancat) made their first contribution in [#801](jdx/hk#801) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

greptile-apps Bot reviewed Apr 5, 2026

View reviewed changes

Comment thread test/go_builtins.bats Outdated

gemini-code-assist Bot reviewed Apr 5, 2026

View reviewed changes

jdx and others added 2 commits April 5, 2026 14:04

jdx enabled auto-merge (squash) April 5, 2026 17:04

jdx merged commit bc18ca2 into main Apr 5, 2026
20 checks passed

jdx deleted the fix/go-builtins-multi-package branch April 5, 2026 17:12

jdx mentioned this pull request Apr 5, 2026

chore: release v1.41.0 #793

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(builtins): use workspace_indicator for Go package-level analysis tools#803

fix(builtins): use workspace_indicator for Go package-level analysis tools#803
jdx merged 3 commits intomainfrom
fix/go-builtins-multi-package

jdx commented Apr 5, 2026 •

edited by cursor Bot

Loading

Uh oh!

greptile-apps Bot commented Apr 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		check = "cd {{workspace}} && golangci-lint run --fix=false ./..."
		fix = "cd {{workspace}} && golangci-lint run --fix ./..."

Uh oh!

Conversation

jdx commented Apr 5, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

greptile-apps Bot commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Flowchart

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented Apr 5, 2026 •

edited by cursor Bot

Loading

greptile-apps Bot commented Apr 5, 2026 •

edited

Loading