fix(release): make release notes editorialization non-blocking by jdx · Pull Request #690 · jdx/hk

jdx · 2026-02-11T15:57:38Z

Summary

Script writes parsed title/notes to an output directory instead of stdout for better CI log visibility
Claude's stdout/stderr flows through naturally instead of being suppressed
Add continue-on-error so failures don't block releases

Test plan

Trigger a release and verify the editorialize step logs are visible
If Claude produces bad output, the release still succeeds

🤖 Generated with Claude Code

Note

Low Risk
Low risk CI/release workflow changes; main risk is degraded release note formatting if the new Claude output parsing or output-dir handling fails (with git-cliff and placeholder fallbacks).

Overview
Release creation no longer blocks on LLM release notes. The Generate release notes step in release.yml is now continue-on-error, and gh release create is guarded to always have a release-notes.md fallback.

Release-note generation flow changed. mise run gen-release-notes now writes title and notes to an explicit output directory (instead of relying on stdout/temp-file writing), parses Claude output for the # vX.X.X - ... header, appends a changelog <details> block, and the workflow copies these files into the release title/body.

^{Written by Cursor Bugbot for commit 7b4093d. This will update automatically on new commits. Configure here.}

gemini-code-assist · 2026-02-11T15:57:55Z

Summary of Changes

Hello @jdx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the gen-release-notes script, which uses Claude Code to generate editorialized release notes. The primary goal is to enhance the robustness and visibility of the release notes generation process within CI/CD pipelines. By directing output to files and allowing Claude's output to flow naturally, the script now better supports non-blocking release workflows, where failures in note generation can be observed without halting the entire release.

Highlights

Output Management: The script now writes the editorialized release title and notes to dedicated files within a specified output directory, improving CI log visibility and structured output.
Error Visibility: Claude's standard error and output messages are no longer suppressed or redirected to temporary files, allowing them to flow naturally for immediate debugging and monitoring.
Argument Handling: The script's argument parsing has been updated to leverage mise's built-in USAGE directives, making argument definition and help messages more declarative.

Changelog

mise-tasks/gen-release-notes
- Updated argument parsing to use mise's USAGE directives, replacing manual positional argument handling.
- Added MISE description for the task.
- Created the specified output directory (output_dir) at the start of execution.
- Removed the redirection of Claude's stderr to a temporary file, allowing direct output.
- Modified the script to extract the release title and body from Claude's output and write them to separate title and notes files within the output_dir.
- Removed the direct echo of the full output to stdout, replacing it with writing to files.
- Added an echo "Raw output:" before printing Claude's raw output for debugging.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/release.yml

Activity

The author provided a test plan including verifying visible logs during a release and ensuring the release still succeeds even if Claude produces bad output.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the gen-release-notes script to better integrate with mise and CI workflows. Key changes include using mise for argument parsing, writing output to files instead of stdout, and allowing Claude's logs to flow through for better visibility. These are positive changes for robustness and debugging. My feedback focuses on improving the script's adherence to shell scripting best practices by directing all logging and error messages to stderr.

gemini-code-assist · 2026-02-11T15:59:29Z


 if [[ -z $changelog ]]; then
-	echo "Error: No changes found for release" >&2
+	echo "Error: No changes found for release"


Error messages should be redirected to standard error (stderr) instead of standard output (stdout). This is a standard practice in shell scripting that allows for separation of diagnostic messages from normal output.

This issue is present in multiple places in this file. Please redirect all error messages to stderr (e.g., on lines 73, 79, and 87).

echo "Error: No changes found for release" >&2

gemini-code-assist · 2026-02-11T15:59:29Z

+echo "Generating release notes with Claude..."
+echo "Version: $version"
+echo "Previous version: ${prev_version:-none}"
+echo "Changelog length: ${#changelog} chars"


It's good practice to send progress and informational messages to stderr to keep stdout clean for potential data output. Although this script now writes its main output to files, adhering to this convention improves script reusability and predictability.

This applies to other log messages in this script as well (e.g., on lines 91-92 and 104).

echo "Generating release notes with Claude..." >&2 echo "Version: $version" >&2 echo "Previous version: ${prev_version:-none}" >&2 echo "Changelog length: ${#changelog} chars" >&2

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON, but a Cloud Agent failed to start.}

- Script writes parsed title/notes to an output directory instead of stdout for better CI log visibility - Claude stdout/stderr flows through naturally instead of being suppressed - Add continue-on-error so failures do not block releases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [hk](https://github.com/jdx/hk) | minor | `1.36.0` → `1.38.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>jdx/hk (hk)</summary> ### [`v1.38.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1380---2026-03-06) [Compare Source](jdx/hk@v1.37.0...v1.38.0) ##### 🚀 Features - **(hook)** add `fail_on_fix` option by [@jdx](https://github.com/jdx) in [#725](jdx/hk#725) ##### 🐛 Bug Fixes - **(builtins)** remove redundant check/check\_diff from builtins by [@nkakouros](https://github.com/nkakouros) in [#726](jdx/hk#726) ##### 📦️ Dependency Updates - update anthropics/claude-code-action digest to [`26ec041`](jdx/hk@26ec041) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#720](jdx/hk#720) - update jdx/mise-action digest to [`e79ddf6`](jdx/hk@e79ddf6) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#721](jdx/hk#721) - update actions-rust-lang/setup-rust-toolchain digest to [`a0b538f`](jdx/hk@a0b538f) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#719](jdx/hk#719) - update rust crate tokio to v1.50.0 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#722](jdx/hk#722) ### [`v1.37.0`](https://github.com/jdx/hk/blob/HEAD/CHANGELOG.md#1370---2026-03-03) [Compare Source](jdx/hk@v1.36.0...v1.37.0) ##### 🚀 Features - **(hook)** add env support to hooks by [@jdx](https://github.com/jdx) in [#709](jdx/hk#709) - parse Go-style diffs by [@jdx](https://github.com/jdx) in [#704](jdx/hk#704) ##### 🐛 Bug Fixes - **(builtins)** strip extra trailing newlines in end-of-file-fixer by [@jdx](https://github.com/jdx) in [#708](jdx/hk#708) - **(docs)** correctly document what --all is about by [@nkakouros](https://github.com/nkakouros) in [#715](jdx/hk#715) - **(git)** exclude untracked files from unstaged\_files set by [@nkakouros](https://github.com/nkakouros) in [#716](jdx/hk#716) - **(hkrc)** config format and load order by [@ivy](https://github.com/ivy) in [#710](jdx/hk#710) - **(release)** write release notes to file instead of capturing stdout by [@jdx](https://github.com/jdx) in [#688](jdx/hk#688) - **(release)** make release notes editorialization non-blocking by [@jdx](https://github.com/jdx) in [#690](jdx/hk#690) - **(step)** gate check\_diff forced check\_first on Fix mode only by [@nkakouros](https://github.com/nkakouros) in [#717](jdx/hk#717) ##### 📚 Documentation - **(shanty)** add audio player with sea shanty recording by [@jdx](https://github.com/jdx) in [67a25ad](jdx/hk@67a25ad) - document config file search paths by [@ivy](https://github.com/ivy) in [#701](jdx/hk#701) - require AI disclosure on GitHub comments by [@jdx](https://github.com/jdx) in [#703](jdx/hk#703) ##### 🔍 Other Changes - replace gen-release-notes script with communique by [@jdx](https://github.com/jdx) in [#700](jdx/hk#700) - add autofix.ci workflow by [@jdx](https://github.com/jdx) in [#705](jdx/hk#705) ##### 📦️ Dependency Updates - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#686](jdx/hk#686) - update taiki-e/upload-rust-binary-action digest to [`f391289`](jdx/hk@f391289) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#692](jdx/hk#692) - update anthropics/claude-code-action digest to [`c22f7c3`](jdx/hk@c22f7c3) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#691](jdx/hk#691) - update rust crate libc to v0.2.181 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#694](jdx/hk#694) - update rust crate clap to v4.5.58 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#693](jdx/hk#693) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#695](jdx/hk#695) - update anthropics/claude-code-action digest to [`edd85d6`](jdx/hk@edd85d6) by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#698](jdx/hk#698) - update rust crate clap to v4.5.60 by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#699](jdx/hk#699) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#702](jdx/hk#702) - lock file maintenance by [@renovate\[bot\]](https://github.com/renovate\[bot]) in [#711](jdx/hk#711) ##### New Contributors - [@ivy](https://github.com/ivy) made their first contribution in [#710](jdx/hk#710) - [@nkakouros](https://github.com/nkakouros) made their first contribution in [#715](jdx/hk#715) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

gemini-code-assist Bot reviewed Feb 11, 2026

View reviewed changes

cursor Bot reviewed Feb 11, 2026

View reviewed changes

Comment thread .github/workflows/release.yml

cursor Bot reviewed Feb 11, 2026

View reviewed changes

Comment thread .github/workflows/release.yml

jdx and others added 2 commits February 11, 2026 12:59

fix(release): redirect diagnostic messages to stderr and fix fallback

7b4093d

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jdx force-pushed the fix/release-notes-non-blocking branch from f138eb9 to 7b4093d Compare February 11, 2026 19:00

jdx merged commit 578aff8 into main Feb 12, 2026
18 checks passed

jdx deleted the fix/release-notes-non-blocking branch February 12, 2026 00:54

jdx mentioned this pull request Feb 12, 2026

chore: release v1.38.0 #687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(release): make release notes editorialization non-blocking#690

fix(release): make release notes editorialization non-blocking#690
jdx merged 2 commits intomainfrom
fix/release-notes-non-blocking

jdx commented Feb 11, 2026 •

edited by cursor Bot

Loading

Uh oh!

gemini-code-assist Bot commented Feb 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Feb 11, 2026

Uh oh!

gemini-code-assist Bot Feb 11, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jdx commented Feb 11, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist Bot commented Feb 11, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jdx commented Feb 11, 2026 •

edited by cursor Bot

Loading