refactor: use xx utilities and drop unused dependencies#653
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
7179c23 to
f49982a
Compare
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
f49982a to
96e64a8
Compare
- Replace `which` crate with `xx::file::which()` in config.rs - Remove unused `getrandom` direct dependency - Update xx submodule to v2.5.0 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
96e64a8 to
fba1249
Compare
Includes fix for Windows same_file using stable API. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Merged
jdx
added a commit
that referenced
this pull request
Feb 1, 2026
### 🚀 Features - **(init)** add auto-detection and interactive mode by [@jdx](https://github.com/jdx) in [#656](#656) - **(stash)** use haiku names for stash patch backups by [@jdx](https://github.com/jdx) in [#655](#655) - add git worktree support by [@jdx](https://github.com/jdx) in [#651](#651) - add "did you mean?" suggestions for typos by [@jdx](https://github.com/jdx) in [#654](#654) ### 🚜 Refactor - use xx utilities and drop unused dependencies by [@jdx](https://github.com/jdx) in [#653](#653) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk release bookkeeping: mainly version string/package URL updates and regenerated CLI docs, with no substantive runtime logic changes. > > **Overview** > Releases **v1.35.0** by updating crate versions (`Cargo.toml`/`Cargo.lock`) and adding the `1.35.0` entry to `CHANGELOG.md`. > > Regenerates documentation and examples to reference `v1.35.0` package URLs and CLI version metadata, and updates `hk init` docs/usage to include the new `--interactive` flag. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 46c426e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: mise-en-dev <123107610+mise-en-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whichcrate withxx::file::which()in config.rsgetrandomdirect dependency (it was declared but never used in source code)Test plan
cargo testpasses🤖 Generated with Claude Code
Note
Low Risk
Low risk: small refactor in
pklCLI detection plus dependency/lockfile cleanup; behavior should be equivalent aside fromwhichresolution edge-cases.Overview
Refactors
run_pklinsrc/config.rsto usexx::file::which("pkl")instead of thewhichcrate when deciding whether to fall back tomise.Cleans up dependencies by removing unused direct deps (
getrandom,which) fromCargo.toml, and updatesCargo.lockwith bumped crate versions (notablyxxto2.5.1) and removal of now-unneeded transitive crates.Written by Cursor Bugbot for commit d40da5b. This will update automatically on new commits. Configure here.