Conversation
422ec2e to
576f161
Compare
4486d4a to
a551422
Compare
a3e297a to
3f4ea48
Compare
jdx
pushed a commit
that referenced
this pull request
Jan 5, 2026
I noticed that in a fair number of CI runs ([#566](https://github.com/jdx/hk/actions/runs/20628763525/job/59243530702?pr=566#step:8:1112), [#553](https://github.com/jdx/hk/actions/runs/20626472664/job/59237860167?pr=553#step:8:1074), [#535](https://github.com/jdx/hk/actions/runs/20626477180/job/59237893712?pr=535#step:8:1046)) the `cargo_check` builtin's tests were failing, seemingly related to the [`+nightly` toolchain the `check` command uses](https://github.com/jdx/hk/blob/main/pkl/builtins/cargo_check.pkl#L13). Since the GitHub images don't include the nightly toolchain by default (in [`ubuntu-latest`](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#rust-tools) or [`macos-latest`](https://github.com/actions/runner-images/blob/main/images/macos/macos-15-arm64-Readme.md#rust-tools)), I thought it would be worth installing it as part of the setup before running the tests. I was able to reproduce the issue locally using [`act`](https://github.com/nektos/act) and after applying my proposed change, I no longer experienced this failure locally. Signed-off-by: Joonas Bergius <joonas@bergi.us>
d334790 to
5679e29
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
2bbd795 to
e23a13c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.29.0 - 2026-01-06
🚀 Features
fixtocargo_checkbuiltin (runningcargo fix) by @thejcannon in #555🐛 Bug Fixes
jqbuiltin by @thejcannon in #533rgcommand in the tasks by @thejcannon in #534settings.tomlandConfig.pklagree on keys by @thejcannon in #539check_list_filestocargo_fmtbuiltin by @thejcannon in #542jq'scheckcommand by @thejcannon in #549🚜 Refactor
📚 Documentation
workspace_indicatorexample by @hituzi-no-sippo in #573🧪 Testing
actionlinttest by @thejcannon in #537check_builtin tests by @thejcannon in #536rustfmtandcargo_formatby @thejcannon in #540📦️ Dependency Updates
Note
Releases
1.29.0and aligns all references across the repo.versionto1.29.0inCargo.toml,Cargo.lock(packagehk), CLI usage (docs/cli/*,hk.usage.kdl)v1.28.0withv1.29.0in docs and examples (docs/*,hk-example.pkl,hk.pklcomment)v1.29.0(src/cli/init.rs) and adjust config error hint (src/config.rs)CHANGELOG.mdentry for1.29.0describing features, fixes, refactors, tests, and dependency updatesWritten by Cursor Bugbot for commit ae7540f. This will update automatically on new commits. Configure here.