docs: include linux native packages in aube lock#423
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the lockfile to include several platform-specific packages for esbuild and rollup and introduces a supportedArchitectures configuration in package.json. Feedback focuses on ensuring the supportedArchitectures list is comprehensive; specifically, darwin, arm64, and musl should be added to their respective categories to match the packages present in the lockfile and prevent them from being pruned during future updates in different environments.
| "os": [ | ||
| "current", | ||
| "linux" | ||
| ], |
There was a problem hiding this comment.
To ensure the lockfile remains universal and doesn't prune macOS-specific packages when updated on Linux (or vice versa), it's recommended to explicitly include darwin in the os list. The current lockfile already contains Darwin packages that would otherwise be removed if regenerated on a Linux machine.
"os": [
"current",
"linux",
"darwin"
],| "cpu": [ | ||
| "current", | ||
| "x64" | ||
| ], |
There was a problem hiding this comment.
The cpu list should explicitly include arm64. Since the lockfile diff shows several arm64 packages being added (e.g., @esbuild/linux-arm64), making this explicit prevents them from being removed if the lockfile is regenerated on an Intel-based machine where "current" would resolve to x64.
"cpu": [
"current",
"x64",
"arm64"
],| "libc": [ | ||
| "current", | ||
| "glibc" | ||
| ] |
There was a problem hiding this comment.
The libc list is missing musl, yet the lockfile diff includes musl variants for Rollup (e.g., @rollup/rollup-linux-x64-musl). Adding musl here ensures support for environments like Alpine Linux and maintains consistency with the committed lockfile state.
"libc": [
"current",
"glibc",
"musl"
]
Greptile SummaryFixes the docs deploy failure on Ubuntu by adding Confidence Score: 5/5Safe to merge — targeted, well-validated fix for a CI infrastructure issue with no logic or security concerns. All changes are confined to the lock file and package.json metadata. The fix is directly validated by a successful local docs:build run as documented in the PR description. No application logic is altered. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pnpm install / aube install] --> B{supportedArchitectures?}
B -- Before PR\nmacOS only --> C[Lock includes\ndarwin-arm64 / darwin-x64\nnatives only]
B -- After PR\ncurrent + linux / x64 / glibc --> D[Lock includes\ndarwin + linux-x64-gnu\nlinux-arm64-gnu etc.]
C --> E[Ubuntu CI: rollup-linux-x64-gnu\nnot in lock → build fails]
D --> F[Ubuntu CI: rollup-linux-x64-gnu\npresent → docs:build succeeds]
Reviews (1): Last reviewed commit: "docs: include linux native packages in a..." | Re-trigger Greptile |
### 🚀 Features - Powershell integration by [@nbfritch](https://github.com/nbfritch) in [#421](#421) ### 🐛 Bug Fixes - **(Windows)** Nushell integration by [@john-trieu-nguyen](https://github.com/john-trieu-nguyen) in [#425](#425) - **(Windows)** Command resolution for executables by [@john-trieu-nguyen](https://github.com/john-trieu-nguyen) in [#427](#427) ### 📚 Documentation - add releases nav and aube lock by [@jdx](https://github.com/jdx) in [#422](#422) - include linux native packages in aube lock by [@jdx](https://github.com/jdx) in [#423](#423) ### 🔍 Other Changes - Use published `clap-sort` crate instead of inlined module by [@jdx](https://github.com/jdx) in [#409](#409) - add communique 1.0.1 by [@jdx](https://github.com/jdx) in [#424](#424) ### 📦️ Dependency Updates - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#381](#381) - update taiki-e/upload-rust-binary-action digest to 10c1cf6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#383](#383) - update rust crate tokio to v1.51.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#384](#384) - update rust crate indexmap to v2.14.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#385](#385) - update rust crate rmcp to v1.4.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#389](#389) - update rust crate strum to 0.28 by [@renovate[bot]](https://github.com/renovate[bot]) in [#395](#395) - update rust crate toml_edit to 0.25 by [@renovate[bot]](https://github.com/renovate[bot]) in [#396](#396) - update rust crate miniz_oxide to 0.9 by [@renovate[bot]](https://github.com/renovate[bot]) in [#390](#390) - update rust crate ratatui to 0.30 by [@renovate[bot]](https://github.com/renovate[bot]) in [#392](#392) - update actions/checkout action to v6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#397](#397) - update actions/deploy-pages action to v5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#399](#399) - update actions/configure-pages action to v6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#398](#398) - update actions/setup-node action to v6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#400](#400) - update actions/upload-pages-artifact action to v4 by [@renovate[bot]](https://github.com/renovate[bot]) in [#401](#401) - update dependency node to v24 by [@renovate[bot]](https://github.com/renovate[bot]) in [#403](#403) - update apple-actions/import-codesign-certs action to v6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#402](#402) - update nick-fields/retry action to v4 by [@renovate[bot]](https://github.com/renovate[bot]) in [#406](#406) - update github artifact actions (major) by [@renovate[bot]](https://github.com/renovate[bot]) in [#404](#404) - update jdx/mise-action action to v4 by [@renovate[bot]](https://github.com/renovate[bot]) in [#405](#405) - update rust crate which to v8 by [@renovate[bot]](https://github.com/renovate[bot]) in [#408](#408) - update rust crate usage-lib to v3 by [@renovate[bot]](https://github.com/renovate[bot]) in [#407](#407) - bump rustcrypto stack (aes-gcm, sha2, hkdf) together by [@jdx](https://github.com/jdx) in [#410](#410) - update rust crate reqwest to 0.13 by [@renovate[bot]](https://github.com/renovate[bot]) in [#393](#393) - update rust crate libloading to 0.9 by [@renovate[bot]](https://github.com/renovate[bot]) in [#388](#388) - update rust crate keepass to 0.10 by [@renovate[bot]](https://github.com/renovate[bot]) in [#387](#387) - update rust crate rand to 0.10 by [@renovate[bot]](https://github.com/renovate[bot]) in [#391](#391) - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#411](#411) - update rust crate google-cloud-secretmanager-v1 to v1.8.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#415](#415) - update actions/upload-pages-artifact action to v5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#418](#418) - update rust crate rmcp to v1.5.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#416](#416) - update rust crate clap to v4.6.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#413](#413) - update rust crate tokio to v1.52.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#417](#417) - update rust crate keepass to v0.10.6 by [@renovate[bot]](https://github.com/renovate[bot]) in [#414](#414) - update taiki-e/upload-rust-binary-action digest to f0d45ae by [@renovate[bot]](https://github.com/renovate[bot]) in [#419](#419) - update rust crate aws-sdk-sts to v1.102.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#420](#420) ### New Contributors - @john-trieu-nguyen made their first contribution in [#427](#427) - @nbfritch made their first contribution in [#421](#421)
Summary
Fixes the docs deploy failure from https://github.com/jdx/fnox/actions/runs/24634895084/job/72028485580 by making the aube lock include Linux native optional packages.
The docs job failed on Ubuntu with Rollup unable to load
@rollup/rollup-linux-x64-gnu. The existing lock was generated on macOS, so the Linux native package was absent.Changes
pnpm.supportedArchitecturesto include current platform plus Linux x64 glibc.aube-lock.yamlso Rollup/esbuild Linux packages are present.Validation
mise x aube@latest -- aube install --lockfile-only --forcemise x npm:prettier@3.6.2 -- prettier --write package.json aube-lock.yamlrm -rf node_modules && mise x -- aube installmise x -- aube run docs:buildmise x npm:prettier@3.6.2 -- prettier --check package.json aube-lock.yamlNote
Low Risk
Low risk lockfile/config change that only affects dependency resolution; main risk is slightly larger installs or unexpected native binary selection on CI/Linux.
Overview
Fixes Linux docs build/deploy by ensuring platform-specific native optional deps are present in the lockfile.
Adds
pnpm.supportedArchitecturesinpackage.jsonto include Linuxx64/glibc(alongside current), and regeneratesaube-lock.yamlsorollupandesbuildLinux (and additional Darwin) native packages are recorded and resolved consistently across CI runners.Reviewed by Cursor Bugbot for commit 61d2f02. Bugbot is set up for automated code reviews on this repo. Configure here.