Skip to content

Add docker dependency option to oras in setup.py#164

Merged
patrykkulik-microsoft merged 1 commit intomainfrom
achurchard/fix-oras-docker-dependency-bug
Mar 27, 2024
Merged

Add docker dependency option to oras in setup.py#164
patrykkulik-microsoft merged 1 commit intomainfrom
achurchard/fix-oras-docker-dependency-bug

Conversation

@Cyclam
Copy link
Copy Markdown
Collaborator

@Cyclam Cyclam commented Mar 27, 2024

The Oras library we use has the Python docker module as an optional requirement. We do use that branch of Oras's code, so need the module. We didn't have the optional requirement turned on, so if you didn't already have the Python docker module installed, the AOSM CLI broke.

This PR adds the docker option into setup.py.

Testing

Tobias Weiserth hit this. Confirmed fixed after this change.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants