Replace the WASAPI boolean option with a modern feature flag#1
Closed
codeofdusk wants to merge 5 commits into
Closed
Replace the WASAPI boolean option with a modern feature flag#1codeofdusk wants to merge 5 commits into
codeofdusk wants to merge 5 commits into
Conversation
… code comment for explanation.
…ately controlled in the system Volume Mixer. Split NVDA sounds into their own session. Support setting the volume of a session.
6 tasks
Author
|
CC @jcsteh. |
Owner
|
Thanks for working on this. Having chatted to @michaelDCurran about this, it's unclear that a feature flag provides an advantage here. That said, as I noted on the original PR, I'm happy to do that if the core devs require it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves my review action in nvaccess#14697.