Remove SaveSignalHandlingModel#582
Merged
foarsitter merged 1 commit intojazzband:masterfrom Nov 6, 2023
Merged
Conversation
cdca114 to
11f3a53
Compare
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 95.12% 95.08% -0.04%
==========================================
Files 6 6
Lines 820 794 -26
==========================================
- Hits 780 755 -25
+ Misses 40 39 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
I have no objection against dropping |
Contributor
Author
|
If we remove |
foarsitter
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SaveSignalHandlingModelis out of sync with upstream Django, missing bug fixes and completely broken on Django 5.0. I don’t want to check it against all supported Django versions, and I expect it will go out of sync again.SaveSignalHandlingModelwas added in #285 but hasn't seen any development since. It seems unpopular since there have been no issues reported, and the only results on GitHub code search are from django-model-utils copies: https://github.com/search?q=SaveSignalHandlingModel+language%3APython&type=code&l=PythonAlso, the class is probably unnecessary in most cases since
bulk_create()bypasses signals, so an easy replacement:Bypassing a specific receiver can be done by adding a thread-local flag to those receivers.
Solution
Drop
SaveSignalHandlingModel.Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.