Feature/disable model save signals#285
Merged
auvipy merged 3 commits intojazzband:masterfrom May 20, 2019
Merged
Conversation
auvipy
suggested changes
Mar 12, 2019
Contributor
auvipy
left a comment
There was a problem hiding this comment.
please fix merge conflicts
Member
|
@ebsaral any chance to fix the merge conflicts? |
Contributor
Author
Ah, sorry. I will do it today. Peace. |
2ce55f2 to
b99307a
Compare
Contributor
Author
|
@auvipy Fixed merge conflicts. |
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 91.56% 91.72% +0.15%
==========================================
Files 6 6
Lines 735 761 +26
==========================================
+ Hits 673 698 +25
- Misses 62 63 +1
Continue to review full report at Codecov.
|
b99307a to
f5d4e5c
Compare
auvipy
approved these changes
May 20, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When saving an object, I want to disable pre_save/post_save signals.
Solution
I overwrote the save method of the base model class.
Commandments
CHANGES.rstfile to describe the changes, and quote according issue withGH-<issue_number>.