Skip to content

german translation of code editors #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
higoka wants to merge 16 commits into from
Closed

german translation of code editors #5

higoka wants to merge 16 commits into from

Conversation

@higoka
Copy link

@higoka higoka commented Jan 14, 2020

No description provided.

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Jan 14, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 14, 2020 10:01
@claassistantio
Copy link

claassistantio commented Jan 14, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

christianhegedues
christianhegedues reviewed Jan 14, 2020
View reviewed changes
higoka and others added 7 commits January 15, 2020 07:19
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
6d536e7 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
3fd85e7 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
3c3a021 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
03f41a7 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
92f6ee4 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
45f6f13 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
@higoka @christianhegedues
Update 1-js/01-getting-started/3-code-editors/article.md
17665a0 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
1H0
1H0 suggested changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@1H0 1H0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should agree that we all translate the article in the du-form. So that we are consistent through the articles.

@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 20, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jan 20, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@1H0
Copy link
Contributor

1H0 commented Jan 20, 2020

Just saw that the topic was not reserved by you and that @MichFriee reserved and translated the page in another PR. Please make sure to always check first, if the article isn't already taken and to reserve it first...

Ok when I close this PR and you take another article?

higoka and others added 5 commits January 20, 2020 15:11
@higoka @1H0
Update 1-js/01-getting-started/3-code-editors/article.md
69b9025 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@higoka @1H0
Update 1-js/01-getting-started/3-code-editors/article.md
a53f3a1 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@higoka @1H0
Update 1-js/01-getting-started/3-code-editors/article.md
7857da3 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@higoka @1H0
Update 1-js/01-getting-started/3-code-editors/article.md
5422b7c 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@higoka @1H0
Update 1-js/01-getting-started/3-code-editors/article.md
9ad87eb 
Co-Authored-By: Lukas <37246258+1H0@users.noreply.github.com>
@higoka
Copy link
Author

higoka commented Jan 20, 2020

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 20, 2020
@javascript-translate-bot javascript-translate-bot requested a review from a team January 20, 2020 14:13
@1H0 1H0 added the partially reviewed Last review only took a part of the article. Full re-review (not just changes since last) required label Jan 21, 2020
JoeGab
JoeGab suggested changes Jan 21, 2020
View reviewed changes
@javascript-translate-bot javascript-translate-bot added changes requested Waiting for changes and /done from PR author and removed review needed Review needed, please approve or request changes labels Jan 21, 2020
@javascript-translate-bot
Copy link

javascript-translate-bot commented Jan 21, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

higoka and others added 3 commits January 21, 2020 15:05
@higoka @JoeGab
Update 1-js/01-getting-started/3-code-editors/article.md
a9f0e7b 
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
@higoka @JoeGab
Update 1-js/01-getting-started/3-code-editors/article.md
5e49306 
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
@higoka @JoeGab
Update 1-js/01-getting-started/3-code-editors/article.md
389855d 
Co-Authored-By: Gabriel Jörg <jergo3020@gmail.com>
@higoka
Copy link
Author

higoka commented Jan 21, 2020

/done

@javascript-translate-bot javascript-translate-bot added review needed Review needed, please approve or request changes and removed changes requested Waiting for changes and /done from PR author labels Jan 21, 2020
@MichFrie
Copy link
Contributor

MichFrie commented Jan 21, 2020

Hi 1HO, sorry for the confusion, please feel free to close my commit and use the other translation if that's helpful

@1H0
Copy link
Contributor

1H0 commented Jan 24, 2020

Hi @MichFrie!

You did everything right! You reserved the topic first, so it's fine! Just make sure to implement the changes requesten on your PR. Then we can merge your one!

I think i have to close this one now... Since it was translated twice...

@1H0
Copy link
Contributor

1H0 commented Jan 24, 2020

Duplicated translation... @MichFrie reserved the Topic properly, because of that we'll merge his one when the requested changes are implemented.

Sorry @higoka ... 😞 Make sure to properly claim the topics in the future!

@1H0 1H0 closed this Jan 24, 2020
javascript-translate-bot pushed a commit that referenced this pull request Mar 24, 2020
@aniketkudale
Merge pull request #5 from javascript-tutorial/master
4f6356b 
Updated Repo
SirCodewright added a commit to SirCodewright/de.javascript.info that referenced this pull request Apr 5, 2020
@SirCodewright @christianhegedues
Review issues / update javascript-tutorial#5
d2a7712 
Co-Authored-By: Christian Hegedüs <christianhegedues@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianhegedues christianhegedues christianhegedues left review comments

+2 more reviewers

@JoeGab JoeGab JoeGab requested changes

@1H0 1H0 1H0 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

partially reviewed Last review only took a part of the article. Full re-review (not just changes since last) required review needed Review needed, please approve or request changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@higoka @claassistantio @javascript-translate-bot @1H0 @MichFrie @christianhegedues @JoeGab