[sse] Relax Accept header validation to support multiple content types by Copilot · Pull Request #2474 · javalin/javalin

Copilot · 2025-10-11T19:39:59Z

Plan to relax SSE Accept header validation:

Explore repository structure and understand the issue
Build project and run existing tests to verify current state
Change SseHandler to check if Accept header contains "text/event-stream" instead of exact match
Add test cases for relaxed Accept header validation (multiple formats)
Run tests to verify the change works correctly
Verify no existing functionality is broken
Address review comments: extract helper function and remove unnecessary test

Changes Made

Modified SseHandler.kt to use .contains() instead of exact equality check:

Changed from ctx.header(Header.ACCEPT) == "text/event-stream"
To ctx.header(Header.ACCEPT)?.contains("text/event-stream") == true

Refactored tests in TestSse.kt:

Added getSseWithAcceptHeader() helper function to reduce code duplication
Removed unnecessary test for Accept header with text/event-stream at the end
Updated remaining tests to use the helper function

All 19 SSE tests passing successfully. Browser tests fail as expected (CI environment issue).

Original prompt

This section details on the original issue you should resolve

<issue_title>Relax Accept header in SSE requests</issue_title>
<issue_description>Describe the feature
I spent a few hours to get the SSE "hello world" from the documentation page up and running. Nothing worked until I found issue #2376 with the solution.
My client (SSE library) does not send the "correct" HTTP-Accept header; but I can't change it. The client request header is sent as
Accept: text/event-stream, text/html, application/json
So the condition for the SSE handling should be more relaxed.

Additional context
The exact problematic line is probably

https://github.com/javalin/javalin/blame/02f5676b6e6b0c537d3ec0be9f39728dc40791b5/javalin/src/main/java/io/javalin/http/sse/SseHandler.kt#L14

As I'm by no chance a Kotlin programmer, I can only see the problem and provide the solution, but not in the form of a PR.

The solution is to replace the exact header comparison to a "header contains the string 'text/event-stream'".

As the Accept header denotes the preferences or priorities of the client, it is sufficient when "header starts with the string 'text/event-stream'".</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #2420

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: tipsy <1521451+tipsy@users.noreply.github.com>

tipsy · 2025-10-11T19:55:35Z

+        val body = Unirest.get("${http.origin}/sse")
+            .header("Accept", "text/event-stream, text/html, application/json")
+            .asString()
+            .body


Pull this out into a function

Extracted into getSseWithAcceptHeader() helper function in commit 76fb205.

Extracted into getSseWithAcceptHeader() helper function in f1dae11.

tipsy · 2025-10-11T19:55:50Z

+    @Test
+    fun `sse works with Accept header containing text-event-stream at the end`() = TestUtil.test { app, http ->
+        app.sse("/sse") { it.doAndClose { it.sendEvent(event, data) } }
+        val body = Unirest.get("${http.origin}/sse")
+            .header("Accept", "text/html, application/json, text/event-stream")
+            .asString()
+            .body
+        assertThat(body).contains("event: $event")
+        assertThat(body).contains("data: $data")
+    }


I mean... this one isn't neccessary.

Removed the unnecessary test in commit 76fb205.

Removed the unnecessary test in f1dae11.

tipsy · 2025-10-11T19:56:15Z

@copilot please address review comments,

codecov · 2025-10-11T20:00:25Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.39%. Comparing base (5bc990d) to head (76fb205).

Files with missing lines	Patch %	Lines
...in/src/main/java/io/javalin/http/sse/SseHandler.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #2474   +/-   ##
=========================================
  Coverage     86.39%   86.39%           
- Complexity     1447     1449    +2     
=========================================
  Files           149      149           
  Lines          4646     4646           
  Branches        489      489           
=========================================
  Hits           4014     4014           
  Misses          409      409           
  Partials        223      223

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ecessary test Co-authored-by: tipsy <1521451+tipsy@users.noreply.github.com>

Bumps `javalin.version` from 6.7.0 to 7.0.1. Updates `io.javalin:javalin-bundle` from 6.7.0 to 7.0.1 Release notes *Sourced from [io.javalin:javalin-bundle's releases](https://github.com/javalin/javalin/releases).* > 7.0.1 > ----- > > What's Changed > -------------- > > * [readme] v7 release updates by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2527](https://redirect.github.com/javalin/javalin/pull/2527) > * [micrometer] Fix interference with user-configured request logger by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2533](https://redirect.github.com/javalin/javalin/pull/2533) > * [logging] Allow for multiple request loggers by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2539](https://redirect.github.com/javalin/javalin/pull/2539) > > **Full Changelog**: <javalin/javalin@javalin-parent-7.0.0...javalin-parent-7.0.1> > > 7.0.0 > ----- > > What's Changed > -------------- > > * Fix infinite loop in custom exception handling by [`@LordOfLeaks`](https://github.com/LordOfLeaks) in [javalin/javalin#2423](https://redirect.github.com/javalin/javalin/pull/2423) > * [workflow]: Bump actions/checkout from 4 to 5 in the dependencies group by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2428](https://redirect.github.com/javalin/javalin/pull/2428) > * Add comprehensive GitHub Copilot instructions with commit message convention by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2433](https://redirect.github.com/javalin/javalin/pull/2433) > * Bump and rename sslcontext-kickstart to ayza by [`@Hakky54`](https://github.com/Hakky54) in [javalin/javalin#2434](https://redirect.github.com/javalin/javalin/pull/2434) > * Update Javalin to version 7.0.0-SNAPSHOT with Java 17 requirement by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2431](https://redirect.github.com/javalin/javalin/pull/2431) > * Improve test suite by adding HTTP status code assertions and cleaning up static files tests by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2437](https://redirect.github.com/javalin/javalin/pull/2437) > * [core] Migrate to Jetty 12 by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2444](https://redirect.github.com/javalin/javalin/pull/2444) > * [workflow]: Bump the dependencies group with 3 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2445](https://redirect.github.com/javalin/javalin/pull/2445) > * Optimize static file handling by leveraging Jetty 12 native capabilities by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2447](https://redirect.github.com/javalin/javalin/pull/2447) > * Upgrade Kotlin from 1.9.25 to 2.0.21 and remove JTE integration by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2452](https://redirect.github.com/javalin/javalin/pull/2452) > * [deps] Update Pebble to 3.2.4 and fix package imports for CVE security fix by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2453](https://redirect.github.com/javalin/javalin/pull/2453) > * Update all dependencies and plugins to latest stable versions by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2456](https://redirect.github.com/javalin/javalin/pull/2456) > * [context] add support for quoted charset in content-type header ([#2448](https://redirect.github.com/javalin/javalin/issues/2448)) by [`@Pinusar`](https://github.com/Pinusar) in [javalin/javalin#2449](https://redirect.github.com/javalin/javalin/pull/2449) > * Add onUpgrade method to WebSocket RequestLogger by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2450](https://redirect.github.com/javalin/javalin/pull/2450) > * Fix cookie handling in JavalinTest client by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2459](https://redirect.github.com/javalin/javalin/pull/2459) > * Replace OkHTTP with native JDK HttpClient in javalin-testtools by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2461](https://redirect.github.com/javalin/javalin/pull/2461) > * [ssl] Drop Conscrypt ALPN support from SSL Plugin by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2464](https://redirect.github.com/javalin/javalin/pull/2464) > * [compression] Add preferred compressors list by [`@fabiobento512`](https://github.com/fabiobento512) in [javalin/javalin#2427](https://redirect.github.com/javalin/javalin/pull/2427) > * Add Zstandard compression support using zstd-jni by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2465](https://redirect.github.com/javalin/javalin/pull/2465) > * Fix Missing Allow Header in HTTP 405 Responses by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2468](https://redirect.github.com/javalin/javalin/pull/2468) > * [sse] Relax Accept header validation to support multiple content types by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2474](https://redirect.github.com/javalin/javalin/pull/2474) > * [routing] Support custom HTTP methods by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2478](https://redirect.github.com/javalin/javalin/pull/2478) > * [tests] Fix flakiness in TestRateLimitUtil by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2477](https://redirect.github.com/javalin/javalin/pull/2477) > * [javalin] Move routing to config by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2479](https://redirect.github.com/javalin/javalin/pull/2479) > * [maven] Refactor modules by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2481](https://redirect.github.com/javalin/javalin/pull/2481) > * [github] Improve copilot-instructions.md with comprehensive Javalin patterns and philosophy by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2483](https://redirect.github.com/javalin/javalin/pull/2483) > * [core] Introduce endpoint stack and utilize endpoints more by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2486](https://redirect.github.com/javalin/javalin/pull/2486) > * [async] Improve async handling by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2489](https://redirect.github.com/javalin/javalin/pull/2489) > * [deps] Upgrade OkHttp to 5.3.0 by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2496](https://redirect.github.com/javalin/javalin/pull/2496) > * [core] Add config option to disable old version check warning by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2499](https://redirect.github.com/javalin/javalin/pull/2499) > * Add static keyword to wsBefore and wsAfter in ApiBuilder by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2501](https://redirect.github.com/javalin/javalin/pull/2501) > * [deps] Update Pebble to 4.0.0 by [`@kamenitxan`](https://github.com/kamenitxan) in [javalin/javalin#2502](https://redirect.github.com/javalin/javalin/pull/2502) > * [workflow]: Bump actions/checkout from 5 to 6 in the dependencies group by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2503](https://redirect.github.com/javalin/javalin/pull/2503) > * [config] Rework JavalinConfig by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2504](https://redirect.github.com/javalin/javalin/pull/2504) > * [tests] Add missing test cases by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2506](https://redirect.github.com/javalin/javalin/pull/2506) > * [cors] Use JDK's URI class by [`@Playacem`](https://github.com/Playacem) in [javalin/javalin#2180](https://redirect.github.com/javalin/javalin/pull/2180) > * [micrometer] Restore Micrometer plugin for Javalin7/Jetty12 by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2511](https://redirect.github.com/javalin/javalin/pull/2511) > * [json] Fix NoClassDefFoundError for ObjectMapper on Kotlin 2.x by [`@fahrradflucht`](https://github.com/fahrradflucht) in [javalin/javalin#2510](https://redirect.github.com/javalin/javalin/pull/2510) > * Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2515](https://redirect.github.com/javalin/javalin/pull/2515) > * [routing] Clean up unused interfaces and generics by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2517](https://redirect.github.com/javalin/javalin/pull/2517) ... (truncated) Commits * [`bbe55e5`](javalin/javalin@bbe55e5) [maven-release-plugin] prepare release javalin-parent-7.0.1 * [`f5a4934`](javalin/javalin@f5a4934) [logging] Allow for multiple request loggers ([#2539](https://redirect.github.com/javalin/javalin/issues/2539)) * [`e134377`](javalin/javalin@e134377) [micrometer] Fix interference with user-configured request logger ([#2533](https://redirect.github.com/javalin/javalin/issues/2533)) * [`5b5b2fb`](javalin/javalin@5b5b2fb) [websocket] Fix attributes set in wsBeforeUpgrade not persisting to onConnect * [`d4b8c5b`](javalin/javalin@d4b8c5b) [ratelimitplugin] Fix regression in default key function * [`698995d`](javalin/javalin@698995d) [endpoints] Add option to get the future matched enpoint * [`9c3461f`](javalin/javalin@9c3461f) [docs] Update for v7 * [`6821dea`](javalin/javalin@6821dea) [maven-release-plugin] prepare for next development iteration * [`3e02e28`](javalin/javalin@3e02e28) [maven-release-plugin] prepare release javalin-parent-7.0.0 * [`a02ecb7`](javalin/javalin@a02ecb7) [pom] Publish aggregator poms to fix release deploy * Additional commits viewable in [compare view](javalin/javalin@javalin-parent-6.7.0...javalin-parent-7.0.1) Updates `io.javalin.community.openapi:javalin-openapi-plugin` from 6.7.0 to 7.0.1 Release notes *Sourced from [io.javalin.community.openapi:javalin-openapi-plugin's releases](https://github.com/javalin/javalin-openapi/releases).* > 7.0.0 > ----- > > **Changes** > > * See: <https://javalin.github.io/javalin-openapi/introduction/migration-from-6x.html> > > **Sponsors** > Thanks to everyone who supported me this month 💜 > > **Minimal requirements** > > * Java 17+ / Kotlin 2.3+ > * Javalin 7.0.0 > > **Download** > > * [Wiki / Installation](https://github.com/javalin/javalin-openapi/wiki/1.-Installation) > > 7.0.0-beta.1 > ------------ > > **Changes** > > * Support Javalin 7.0.0-beta.1 > > **Sponsors** > Thanks to everyone who supported me this month 💜 ... (truncated) Commits * [`4a073c8`](javalin/javalin-openapi@4a073c8) [GH-274](https://redirect.github.com/javalin/javalin-openapi/issues/274) Release 7.0.1 (Resolves [#274](https://redirect.github.com/javalin/javalin-openapi/issues/274)) * [`11d10d5`](javalin/javalin-openapi@11d10d5) [GH-273](https://redirect.github.com/javalin/javalin-openapi/issues/273) Restructure dependencies (Fixes [#272](https://redirect.github.com/javalin/javalin-openapi/issues/272)) * [`41b3061`](javalin/javalin-openapi@41b3061) [GH-271](https://redirect.github.com/javalin/javalin-openapi/issues/271) Migration guide from 6.x * [`1669065`](javalin/javalin-openapi@1669065) [GH-271](https://redirect.github.com/javalin/javalin-openapi/issues/271) Redesign core implementation for Javalin 7.x * [`0c6ba93`](javalin/javalin-openapi@0c6ba93) [GH-268](https://redirect.github.com/javalin/javalin-openapi/issues/268) Replace wiki reference with a new docs in README ([#268](https://redirect.github.com/javalin/javalin-openapi/issues/268)) * [`5346ada`](javalin/javalin-openapi@5346ada) chore: adjust module resource path formatting in readme * [`dd49a03`](javalin/javalin-openapi@dd49a03) fix: modify OpenAPI plugin resource path description * [`13e6778`](javalin/javalin-openapi@13e6778) chore: update README for Javalin 7.x changes * [`57ff8f7`](javalin/javalin-openapi@57ff8f7) [GH-264](https://redirect.github.com/javalin/javalin-openapi/issues/264) Drop GitHub Wiki * [`b94bc1f`](javalin/javalin-openapi@b94bc1f) [GH-264](https://redirect.github.com/javalin/javalin-openapi/issues/264) Define custom base path for docs deployed to GitHub pages * Additional commits viewable in [compare view](javalin/javalin-openapi@6.7.0...7.0.1) Updates `io.javalin.community.openapi:javalin-swagger-plugin` from 6.7.0 to 7.0.1 Release notes *Sourced from [io.javalin.community.openapi:javalin-swagger-plugin's releases](https://github.com/javalin/javalin-openapi/releases).* > 7.0.0 > ----- > > **Changes** > > * See: <https://javalin.github.io/javalin-openapi/introduction/migration-from-6x.html> > > **Sponsors** > Thanks to everyone who supported me this month 💜 > > **Minimal requirements** > > * Java 17+ / Kotlin 2.3+ > * Javalin 7.0.0 > > **Download** > > * [Wiki / Installation](https://github.com/javalin/javalin-openapi/wiki/1.-Installation) > > 7.0.0-beta.1 > ------------ > > **Changes** > > * Support Javalin 7.0.0-beta.1 > > **Sponsors** > Thanks to everyone who supported me this month 💜 ... (truncated) Commits * [`4a073c8`](javalin/javalin-openapi@4a073c8) [GH-274](https://redirect.github.com/javalin/javalin-openapi/issues/274) Release 7.0.1 (Resolves [#274](https://redirect.github.com/javalin/javalin-openapi/issues/274)) * [`11d10d5`](javalin/javalin-openapi@11d10d5) [GH-273](https://redirect.github.com/javalin/javalin-openapi/issues/273) Restructure dependencies (Fixes [#272](https://redirect.github.com/javalin/javalin-openapi/issues/272)) * [`41b3061`](javalin/javalin-openapi@41b3061) [GH-271](https://redirect.github.com/javalin/javalin-openapi/issues/271) Migration guide from 6.x * [`1669065`](javalin/javalin-openapi@1669065) [GH-271](https://redirect.github.com/javalin/javalin-openapi/issues/271) Redesign core implementation for Javalin 7.x * [`0c6ba93`](javalin/javalin-openapi@0c6ba93) [GH-268](https://redirect.github.com/javalin/javalin-openapi/issues/268) Replace wiki reference with a new docs in README ([#268](https://redirect.github.com/javalin/javalin-openapi/issues/268)) * [`5346ada`](javalin/javalin-openapi@5346ada) chore: adjust module resource path formatting in readme * [`dd49a03`](javalin/javalin-openapi@dd49a03) fix: modify OpenAPI plugin resource path description * [`13e6778`](javalin/javalin-openapi@13e6778) chore: update README for Javalin 7.x changes * [`57ff8f7`](javalin/javalin-openapi@57ff8f7) [GH-264](https://redirect.github.com/javalin/javalin-openapi/issues/264) Drop GitHub Wiki * [`b94bc1f`](javalin/javalin-openapi@b94bc1f) [GH-264](https://redirect.github.com/javalin/javalin-openapi/issues/264) Define custom base path for docs deployed to GitHub pages * Additional commits viewable in [compare view](javalin/javalin-openapi@6.7.0...7.0.1) Updates `io.javalin:javalin-micrometer` from 6.7.0 to 7.0.1 Release notes *Sourced from [io.javalin:javalin-micrometer's releases](https://github.com/javalin/javalin/releases).* > 7.0.1 > ----- > > What's Changed > -------------- > > * [readme] v7 release updates by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2527](https://redirect.github.com/javalin/javalin/pull/2527) > * [micrometer] Fix interference with user-configured request logger by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2533](https://redirect.github.com/javalin/javalin/pull/2533) > * [logging] Allow for multiple request loggers by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2539](https://redirect.github.com/javalin/javalin/pull/2539) > > **Full Changelog**: <javalin/javalin@javalin-parent-7.0.0...javalin-parent-7.0.1> > > 7.0.0 > ----- > > What's Changed > -------------- > > * Fix infinite loop in custom exception handling by [`@LordOfLeaks`](https://github.com/LordOfLeaks) in [javalin/javalin#2423](https://redirect.github.com/javalin/javalin/pull/2423) > * [workflow]: Bump actions/checkout from 4 to 5 in the dependencies group by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2428](https://redirect.github.com/javalin/javalin/pull/2428) > * Add comprehensive GitHub Copilot instructions with commit message convention by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2433](https://redirect.github.com/javalin/javalin/pull/2433) > * Bump and rename sslcontext-kickstart to ayza by [`@Hakky54`](https://github.com/Hakky54) in [javalin/javalin#2434](https://redirect.github.com/javalin/javalin/pull/2434) > * Update Javalin to version 7.0.0-SNAPSHOT with Java 17 requirement by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2431](https://redirect.github.com/javalin/javalin/pull/2431) > * Improve test suite by adding HTTP status code assertions and cleaning up static files tests by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2437](https://redirect.github.com/javalin/javalin/pull/2437) > * [core] Migrate to Jetty 12 by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2444](https://redirect.github.com/javalin/javalin/pull/2444) > * [workflow]: Bump the dependencies group with 3 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2445](https://redirect.github.com/javalin/javalin/pull/2445) > * Optimize static file handling by leveraging Jetty 12 native capabilities by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2447](https://redirect.github.com/javalin/javalin/pull/2447) > * Upgrade Kotlin from 1.9.25 to 2.0.21 and remove JTE integration by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2452](https://redirect.github.com/javalin/javalin/pull/2452) > * [deps] Update Pebble to 3.2.4 and fix package imports for CVE security fix by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2453](https://redirect.github.com/javalin/javalin/pull/2453) > * Update all dependencies and plugins to latest stable versions by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2456](https://redirect.github.com/javalin/javalin/pull/2456) > * [context] add support for quoted charset in content-type header ([#2448](https://redirect.github.com/javalin/javalin/issues/2448)) by [`@Pinusar`](https://github.com/Pinusar) in [javalin/javalin#2449](https://redirect.github.com/javalin/javalin/pull/2449) > * Add onUpgrade method to WebSocket RequestLogger by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2450](https://redirect.github.com/javalin/javalin/pull/2450) > * Fix cookie handling in JavalinTest client by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2459](https://redirect.github.com/javalin/javalin/pull/2459) > * Replace OkHTTP with native JDK HttpClient in javalin-testtools by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2461](https://redirect.github.com/javalin/javalin/pull/2461) > * [ssl] Drop Conscrypt ALPN support from SSL Plugin by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2464](https://redirect.github.com/javalin/javalin/pull/2464) > * [compression] Add preferred compressors list by [`@fabiobento512`](https://github.com/fabiobento512) in [javalin/javalin#2427](https://redirect.github.com/javalin/javalin/pull/2427) > * Add Zstandard compression support using zstd-jni by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2465](https://redirect.github.com/javalin/javalin/pull/2465) > * Fix Missing Allow Header in HTTP 405 Responses by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2468](https://redirect.github.com/javalin/javalin/pull/2468) > * [sse] Relax Accept header validation to support multiple content types by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2474](https://redirect.github.com/javalin/javalin/pull/2474) > * [routing] Support custom HTTP methods by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2478](https://redirect.github.com/javalin/javalin/pull/2478) > * [tests] Fix flakiness in TestRateLimitUtil by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2477](https://redirect.github.com/javalin/javalin/pull/2477) > * [javalin] Move routing to config by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2479](https://redirect.github.com/javalin/javalin/pull/2479) > * [maven] Refactor modules by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2481](https://redirect.github.com/javalin/javalin/pull/2481) > * [github] Improve copilot-instructions.md with comprehensive Javalin patterns and philosophy by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2483](https://redirect.github.com/javalin/javalin/pull/2483) > * [core] Introduce endpoint stack and utilize endpoints more by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2486](https://redirect.github.com/javalin/javalin/pull/2486) > * [async] Improve async handling by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2489](https://redirect.github.com/javalin/javalin/pull/2489) > * [deps] Upgrade OkHttp to 5.3.0 by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2496](https://redirect.github.com/javalin/javalin/pull/2496) > * [core] Add config option to disable old version check warning by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2499](https://redirect.github.com/javalin/javalin/pull/2499) > * Add static keyword to wsBefore and wsAfter in ApiBuilder by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2501](https://redirect.github.com/javalin/javalin/pull/2501) > * [deps] Update Pebble to 4.0.0 by [`@kamenitxan`](https://github.com/kamenitxan) in [javalin/javalin#2502](https://redirect.github.com/javalin/javalin/pull/2502) > * [workflow]: Bump actions/checkout from 5 to 6 in the dependencies group by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2503](https://redirect.github.com/javalin/javalin/pull/2503) > * [config] Rework JavalinConfig by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2504](https://redirect.github.com/javalin/javalin/pull/2504) > * [tests] Add missing test cases by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2506](https://redirect.github.com/javalin/javalin/pull/2506) > * [cors] Use JDK's URI class by [`@Playacem`](https://github.com/Playacem) in [javalin/javalin#2180](https://redirect.github.com/javalin/javalin/pull/2180) > * [micrometer] Restore Micrometer plugin for Javalin7/Jetty12 by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2511](https://redirect.github.com/javalin/javalin/pull/2511) > * [json] Fix NoClassDefFoundError for ObjectMapper on Kotlin 2.x by [`@fahrradflucht`](https://github.com/fahrradflucht) in [javalin/javalin#2510](https://redirect.github.com/javalin/javalin/pull/2510) > * Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2515](https://redirect.github.com/javalin/javalin/pull/2515) > * [routing] Clean up unused interfaces and generics by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2517](https://redirect.github.com/javalin/javalin/pull/2517) ... (truncated) Commits * [`bbe55e5`](javalin/javalin@bbe55e5) [maven-release-plugin] prepare release javalin-parent-7.0.1 * [`f5a4934`](javalin/javalin@f5a4934) [logging] Allow for multiple request loggers ([#2539](https://redirect.github.com/javalin/javalin/issues/2539)) * [`e134377`](javalin/javalin@e134377) [micrometer] Fix interference with user-configured request logger ([#2533](https://redirect.github.com/javalin/javalin/issues/2533)) * [`5b5b2fb`](javalin/javalin@5b5b2fb) [websocket] Fix attributes set in wsBeforeUpgrade not persisting to onConnect * [`d4b8c5b`](javalin/javalin@d4b8c5b) [ratelimitplugin] Fix regression in default key function * [`698995d`](javalin/javalin@698995d) [endpoints] Add option to get the future matched enpoint * [`9c3461f`](javalin/javalin@9c3461f) [docs] Update for v7 * [`6821dea`](javalin/javalin@6821dea) [maven-release-plugin] prepare for next development iteration * [`3e02e28`](javalin/javalin@3e02e28) [maven-release-plugin] prepare release javalin-parent-7.0.0 * [`a02ecb7`](javalin/javalin@a02ecb7) [pom] Publish aggregator poms to fix release deploy * Additional commits viewable in [compare view](javalin/javalin@javalin-parent-6.7.0...javalin-parent-7.0.1) Updates `io.javalin:javalin-testtools` from 6.7.0 to 7.0.1 Release notes *Sourced from [io.javalin:javalin-testtools's releases](https://github.com/javalin/javalin/releases).* > 7.0.1 > ----- > > What's Changed > -------------- > > * [readme] v7 release updates by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2527](https://redirect.github.com/javalin/javalin/pull/2527) > * [micrometer] Fix interference with user-configured request logger by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2533](https://redirect.github.com/javalin/javalin/pull/2533) > * [logging] Allow for multiple request loggers by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2539](https://redirect.github.com/javalin/javalin/pull/2539) > > **Full Changelog**: <javalin/javalin@javalin-parent-7.0.0...javalin-parent-7.0.1> > > 7.0.0 > ----- > > What's Changed > -------------- > > * Fix infinite loop in custom exception handling by [`@LordOfLeaks`](https://github.com/LordOfLeaks) in [javalin/javalin#2423](https://redirect.github.com/javalin/javalin/pull/2423) > * [workflow]: Bump actions/checkout from 4 to 5 in the dependencies group by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2428](https://redirect.github.com/javalin/javalin/pull/2428) > * Add comprehensive GitHub Copilot instructions with commit message convention by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2433](https://redirect.github.com/javalin/javalin/pull/2433) > * Bump and rename sslcontext-kickstart to ayza by [`@Hakky54`](https://github.com/Hakky54) in [javalin/javalin#2434](https://redirect.github.com/javalin/javalin/pull/2434) > * Update Javalin to version 7.0.0-SNAPSHOT with Java 17 requirement by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2431](https://redirect.github.com/javalin/javalin/pull/2431) > * Improve test suite by adding HTTP status code assertions and cleaning up static files tests by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2437](https://redirect.github.com/javalin/javalin/pull/2437) > * [core] Migrate to Jetty 12 by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2444](https://redirect.github.com/javalin/javalin/pull/2444) > * [workflow]: Bump the dependencies group with 3 updates by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2445](https://redirect.github.com/javalin/javalin/pull/2445) > * Optimize static file handling by leveraging Jetty 12 native capabilities by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2447](https://redirect.github.com/javalin/javalin/pull/2447) > * Upgrade Kotlin from 1.9.25 to 2.0.21 and remove JTE integration by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2452](https://redirect.github.com/javalin/javalin/pull/2452) > * [deps] Update Pebble to 3.2.4 and fix package imports for CVE security fix by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2453](https://redirect.github.com/javalin/javalin/pull/2453) > * Update all dependencies and plugins to latest stable versions by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2456](https://redirect.github.com/javalin/javalin/pull/2456) > * [context] add support for quoted charset in content-type header ([#2448](https://redirect.github.com/javalin/javalin/issues/2448)) by [`@Pinusar`](https://github.com/Pinusar) in [javalin/javalin#2449](https://redirect.github.com/javalin/javalin/pull/2449) > * Add onUpgrade method to WebSocket RequestLogger by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2450](https://redirect.github.com/javalin/javalin/pull/2450) > * Fix cookie handling in JavalinTest client by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2459](https://redirect.github.com/javalin/javalin/pull/2459) > * Replace OkHTTP with native JDK HttpClient in javalin-testtools by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2461](https://redirect.github.com/javalin/javalin/pull/2461) > * [ssl] Drop Conscrypt ALPN support from SSL Plugin by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2464](https://redirect.github.com/javalin/javalin/pull/2464) > * [compression] Add preferred compressors list by [`@fabiobento512`](https://github.com/fabiobento512) in [javalin/javalin#2427](https://redirect.github.com/javalin/javalin/pull/2427) > * Add Zstandard compression support using zstd-jni by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2465](https://redirect.github.com/javalin/javalin/pull/2465) > * Fix Missing Allow Header in HTTP 405 Responses by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2468](https://redirect.github.com/javalin/javalin/pull/2468) > * [sse] Relax Accept header validation to support multiple content types by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2474](https://redirect.github.com/javalin/javalin/pull/2474) > * [routing] Support custom HTTP methods by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2478](https://redirect.github.com/javalin/javalin/pull/2478) > * [tests] Fix flakiness in TestRateLimitUtil by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2477](https://redirect.github.com/javalin/javalin/pull/2477) > * [javalin] Move routing to config by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2479](https://redirect.github.com/javalin/javalin/pull/2479) > * [maven] Refactor modules by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2481](https://redirect.github.com/javalin/javalin/pull/2481) > * [github] Improve copilot-instructions.md with comprehensive Javalin patterns and philosophy by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2483](https://redirect.github.com/javalin/javalin/pull/2483) > * [core] Introduce endpoint stack and utilize endpoints more by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2486](https://redirect.github.com/javalin/javalin/pull/2486) > * [async] Improve async handling by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2489](https://redirect.github.com/javalin/javalin/pull/2489) > * [deps] Upgrade OkHttp to 5.3.0 by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2496](https://redirect.github.com/javalin/javalin/pull/2496) > * [core] Add config option to disable old version check warning by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2499](https://redirect.github.com/javalin/javalin/pull/2499) > * Add static keyword to wsBefore and wsAfter in ApiBuilder by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2501](https://redirect.github.com/javalin/javalin/pull/2501) > * [deps] Update Pebble to 4.0.0 by [`@kamenitxan`](https://github.com/kamenitxan) in [javalin/javalin#2502](https://redirect.github.com/javalin/javalin/pull/2502) > * [workflow]: Bump actions/checkout from 5 to 6 in the dependencies group by [`@dependabot`](https://github.com/dependabot)[bot] in [javalin/javalin#2503](https://redirect.github.com/javalin/javalin/pull/2503) > * [config] Rework JavalinConfig by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2504](https://redirect.github.com/javalin/javalin/pull/2504) > * [tests] Add missing test cases by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2506](https://redirect.github.com/javalin/javalin/pull/2506) > * [cors] Use JDK's URI class by [`@Playacem`](https://github.com/Playacem) in [javalin/javalin#2180](https://redirect.github.com/javalin/javalin/pull/2180) > * [micrometer] Restore Micrometer plugin for Javalin7/Jetty12 by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2511](https://redirect.github.com/javalin/javalin/pull/2511) > * [json] Fix NoClassDefFoundError for ObjectMapper on Kotlin 2.x by [`@fahrradflucht`](https://github.com/fahrradflucht) in [javalin/javalin#2510](https://redirect.github.com/javalin/javalin/pull/2510) > * Extend Context#redirect to beforeMatched and rename skipIfExceptionOccurred by [`@Copilot`](https://github.com/Copilot) in [javalin/javalin#2515](https://redirect.github.com/javalin/javalin/pull/2515) > * [routing] Clean up unused interfaces and generics by [`@tipsy`](https://github.com/tipsy) in [javalin/javalin#2517](https://redirect.github.com/javalin/javalin/pull/2517) ... (truncated) Commits * [`bbe55e5`](javalin/javalin@bbe55e5) [maven-release-plugin] prepare release javalin-parent-7.0.1 * [`f5a4934`](javalin/javalin@f5a4934) [logging] Allow for multiple request loggers ([#2539](https://redirect.github.com/javalin/javalin/issues/2539)) * [`e134377`](javalin/javalin@e134377) [micrometer] Fix interference with user-configured request logger ([#2533](https://redirect.github.com/javalin/javalin/issues/2533)) * [`5b5b2fb`](javalin/javalin@5b5b2fb) [websocket] Fix attributes set in wsBeforeUpgrade not persisting to onConnect * [`d4b8c5b`](javalin/javalin@d4b8c5b) [ratelimitplugin] Fix regression in default key function * [`698995d`](javalin/javalin@698995d) [endpoints] Add option to get the future matched enpoint * [`9c3461f`](javalin/javalin@9c3461f) [docs] Update for v7 * [`6821dea`](javalin/javalin@6821dea) [maven-release-plugin] prepare for next development iteration * [`3e02e28`](javalin/javalin@3e02e28) [maven-release-plugin] prepare release javalin-parent-7.0.0 * [`a02ecb7`](javalin/javalin@a02ecb7) [pom] Publish aggregator poms to fix release deploy * Additional commits viewable in [compare view](javalin/javalin@javalin-parent-6.7.0...javalin-parent-7.0.1) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Initial plan

f5bf2ce

Copilot AI assigned Copilot and tipsy Oct 11, 2025

Copilot started work on behalf of tipsy October 11, 2025 19:40 View session

[sse] Relax Accept header validation to support multiple content types

76fb205

Co-authored-by: tipsy <1521451+tipsy@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix Accept header handling in SSE requests~~ [sse] Relax Accept header validation to support multiple content types Oct 11, 2025

Copilot AI requested a review from tipsy October 11, 2025 19:51

Copilot finished work on behalf of tipsy October 11, 2025 19:51

tipsy requested changes Oct 11, 2025

View reviewed changes

Copilot started work on behalf of tipsy October 11, 2025 19:56 View session

[sse] Address review comments: extract helper function and remove unn…

f1dae11

…ecessary test Co-authored-by: tipsy <1521451+tipsy@users.noreply.github.com>

Copilot AI requested a review from tipsy October 11, 2025 20:02

Copilot finished work on behalf of tipsy October 11, 2025 20:02

tipsy marked this pull request as ready for review October 11, 2025 20:06

tipsy merged commit 971980b into master Oct 11, 2025
24 checks passed

tipsy deleted the copilot/relax-accept-header-sse branch October 11, 2025 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[sse] Relax Accept header validation to support multiple content types#2474

[sse] Relax Accept header validation to support multiple content types#2474
tipsy merged 3 commits into
masterfrom
copilot/relax-accept-header-sse

Copilot AI commented Oct 11, 2025 •

edited

Loading

Uh oh!

tipsy Oct 11, 2025

Uh oh!

Copilot AI Oct 11, 2025

Uh oh!

Copilot AI Oct 11, 2025

Uh oh!

tipsy Oct 11, 2025

Uh oh!

Copilot AI Oct 11, 2025

Uh oh!

Copilot AI Oct 11, 2025

Uh oh!

tipsy commented Oct 11, 2025

Uh oh!

codecov Bot commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Copilot AI commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Comments on the Issue (you are @copilot in this section)

Uh oh!

tipsy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

tipsy Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 11, 2025

Choose a reason for hiding this comment

Uh oh!

tipsy commented Oct 11, 2025

Uh oh!

codecov Bot commented Oct 11, 2025

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 11, 2025 •

edited

Loading