Revert "Fix momentum scrolling on iOS" #5084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8125718.
GeoffreyBooth
added a commit
that referenced
this pull request
Aug 18, 2018
* fix momentum scrolling on iOS (#5083) * Revert "fix momentum scrolling on iOS (#5083)" (#5084) This reverts commit 8125718. * AST tests (WIP) * added tests * cleanup new helpers for cleaner code * more tests tests are mostly complete now. also included one for our helper function. * string quotes * Update dependencies; disable some babel-minify transforms to work around babel/minify#893 (#5095) * more tests + refactor * Remove unused helper function; improve logging output * Add tests for ImportNamespaceSpecifier, Expansion; cleanup * CI: Test first before building, so that the tests run on the committed, built files in /lib; the build parts of CI are only a test that the build process succeeds, so we shouldn't be testing the output of the CI build steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5083
@paulnta Your patch makes the navbar disappear, at least on my iPhone. I thought it was something about rawgit.com when I tested your branch, so I merged your PR in anyway, but now I see the same issue on the live site. Reverting until we can get a patch that doesn’t lose our nav.