Skip to content

Fix #4105: Duplicate variable i defined when evaluating range #4855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GeoffreyBooth merged 1 commit into from
Jan 15, 2018
Merged

Fix #4105: Duplicate variable i defined when evaluating range #4855

GeoffreyBooth merged 1 commit into from
Jan 15, 2018

Conversation

@zdenko
Copy link
Collaborator

@zdenko zdenko commented Jan 12, 2018 •
edited by GeoffreyBooth
Loading

Fixes #4105

a = 3
foo [0..a]
var a;
a = 3;
foo((function() {
  var results = [];
  for (var i = 0; 0 <= a ? i <= a : i >= a; 0 <= a ? i++ : i--){ results.push(i); }
  return results;
}).apply(this));
b = [1..a]
var b;
b = (function() {
  var results = [];
  for (var i = 1; 1 <= a ? i <= a : i >= a; 1 <= a ? i++ : i--){ results.push(i); }
  return results;
}).apply(this);

@GeoffreyBooth
Copy link
Collaborator

GeoffreyBooth commented Jan 15, 2018

Nice work! I love closing 3-year-old bugs.

@GeoffreyBooth GeoffreyBooth merged commit e348026 into jashkenas:master Jan 15, 2018
@benjie
Copy link

benjie commented Jan 15, 2018

🎉

zdenko added a commit to zdenko/coffeescript that referenced this pull request Jan 17, 2018
@zdenko
Fix jashkenas#4105 (jashkenas#4855)
441cac7
GeoffreyBooth pushed a commit that referenced this pull request Feb 1, 2018
@zdenko @GeoffreyBooth
Fix #2047: Infinite loop possible when for loop with range uses v…
9e80f6f 
…ariables (#4853)

* fix #2047

* Additional check for 'step'; tests

* Fix #4105 (#4855)

* Update output

* Throw warning for unsupported runtimes, e.g. Node < 6 (#4839)

* fix #1403 (#4854)

* Update output

* [Change]: Destructuring with non-final spread should still use rest syntax (#4517) (#4825)

* destructuring optimization

* refactor

* minor improvement, fix errors

* minor refactoring

* improvements

* Update output

* Update output

* Fix #4843: bad output when assigning to @prop in destructuring assignment with defaults (#4848)

* fix #4843

* improvements

* typo

* small fix

* Fix #3441: parentheses wrapping expression throw invalid error  (#4849)

* fix #3441

* improvements

* refactor

* Fix #1726: expression in property access causes unexpected results (#4851)

* fix #1726

* Explain what's happening, rather than just linking to an issue

* Updated output

* Optimization

* Update output

* remove casting to number

* cleanup tests
@GeoffreyBooth GeoffreyBooth mentioned this pull request Feb 1, 2018
Merged
This was referenced Feb 3, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zdenko @GeoffreyBooth @benjie