Skip to content

Conversation

@GeoffreyBooth
Copy link
Collaborator

We have to include the version number (e.g. 1.12.1) in package.json; but there’s no reason to duplicate that anywhere else. We can require 'package.json'.

@lydell
Copy link
Collaborator

lydell commented Dec 11, 2016

I like this.

@GeoffreyBooth
Copy link
Collaborator Author

So . . . merge? Should I rebuild the browser compiler first? (That would change the browser compiler in use on coffeescript.org.)

@lydell
Copy link
Collaborator

lydell commented Dec 12, 2016

I was goind to say "Yes, I think we can merge it", but now that you mentioned rebuilding the browser compiler first I hesitated. Why would we do that (instead of at the next release as usual)?

@GeoffreyBooth
Copy link
Collaborator Author

It’s a bit weird when we merge into master, we’re merging revised compiled .js files in lib but we’re not merging the revised compiled browser .js file, I guess because it’s part of the documentation which only gets rebuilt on release. But the documentation doesn’t really need to be versioned, so the browser compiler could change between releases . . .

@connec
Copy link
Collaborator

connec commented Dec 12, 2016

I've not read into how this works, but could we not copy brower.js into the docs folder when docs are built, and use that version in the docs themselves?

@GeoffreyBooth
Copy link
Collaborator Author

docs/v1/browser-compiler/coffee-script.js is a minified concatenation of all the files in lib/coffee-script. lib/coffee-script/browser.js is just the part of the compiler that is browser-specific.

@jashkenas
Copy link
Owner

That's certainly one way to do it. Neat!

@GeoffreyBooth
Copy link
Collaborator Author

So should I merge this as is, or rebuild the browser compiler too?

@GeoffreyBooth GeoffreyBooth merged commit be0f1cb into jashkenas:master Dec 16, 2016
@lydell lydell deleted the dry-version branch December 16, 2016 08:41
EsrefDurna pushed a commit to EsrefDurna/coffeescript that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants