Downcast amg_core and simplify CSR#2
Merged
jarrodmillman merged 4 commits intojarrodmillman:sparse_arraysfrom Oct 17, 2024
Merged
Downcast amg_core and simplify CSR#2jarrodmillman merged 4 commits intojarrodmillman:sparse_arraysfrom
jarrodmillman merged 4 commits intojarrodmillman:sparse_arraysfrom
Conversation
jarrodmillman
added a commit
that referenced
this pull request
Oct 17, 2024
* CI: bump macos image pin from 12 to 13 (scikit-image#7582) * Use scipy.sparse arrays * updates to downcast for amg_core and simplify CSR --------- Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
jarrodmillman
added a commit
that referenced
this pull request
Oct 22, 2024
* CI: bump macos image pin from 12 to 13 (scikit-image#7582) * Use scipy.sparse arrays * updates to downcast for amg_core and simplify CSR --------- Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
jarrodmillman
added a commit
that referenced
this pull request
Oct 23, 2024
* CI: bump macos image pin from 12 to 13 (scikit-image#7582) * Use scipy.sparse arrays * updates to downcast for amg_core and simplify CSR --------- Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
jarrodmillman
added a commit
that referenced
this pull request
Oct 23, 2024
* CI: bump macos image pin from 12 to 13 (scikit-image#7582) * Use scipy.sparse arrays * updates to downcast for amg_core and simplify CSR --------- Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
jarrodmillman
added a commit
that referenced
this pull request
Nov 18, 2024
* CI: bump macos image pin from 12 to 13 (scikit-image#7582) * Use scipy.sparse arrays * updates to downcast for amg_core and simplify CSR --------- Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
jarrodmillman
added a commit
that referenced
this pull request
Nov 19, 2024
* CI: bump macos image pin from 12 to 13 (scikit-image#7582) * Use scipy.sparse arrays * updates to downcast for amg_core and simplify CSR --------- Co-authored-by: Brigitta Sipőcz <bsipocz@gmail.com> Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two lines to convert indptr and indices to
int32before calling the pyamg function. That got rid of one random_walker test failing. I got rid of another by adding a warning message to the list of acceptable warnings in a couple of places. Unfortunately, pyamg still usesisspmatrix_csrinstead ofissparse(A) and A.format in ('csr', 'csc'), so it currently coverts the csr_array we give it to a csr_matrix and raises a warning. I'm sure this is not as performant as it could be.I also noticed a number of places where we create coo_array and then immediately convert to CSR format. I changed those to construct the csr_array because CSR can handle COO style input data. It actually does the conversion for you, so it's probably not much faster, but makes this code easier to read.
Once pyamg gets settled for sparray support, we should remove those warning message fragments from the tests.