fix: remove redundant CI env from workflow steps#870
Merged
agilgur5 merged 1 commit intoSep 20, 2020
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/formium/tsdx/3on34ldzg |
CI=true from github workflows
Collaborator
|
Hmm, yea not sure why these were added in #457. It's not used in TSDX's own internal actions. Good catch and thanks for the helpful link to the docs @leonardodino ! |
agilgur5
approved these changes
Sep 20, 2020
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…r#870) - they're already set by default by GitHub: https://docs.github.com/en/actions/reference/environment-variables#default-environment-variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for adding GH actions to the templates,
it's awesome and greatly reduces overhead of adding CI on new packages.
I always end up needing to read the damm docs again for every project 🙈
nitpick fix on this PR:
CI=trueis already declared at runner level.docs: default-environment-variables