(deps/fix/types): upgrade rollup & fix event type issues#544
Merged
Conversation
- if TSDX were installed directly from git, the `prepare` script would
for some reason fail on these events
- but they wouldn't error when run internally
- when Rollup was upgraded, then they started erroring
- also remove the unnecessary await in front of watch
This was referenced Mar 6, 2020
paul-vd
pushed a commit
to EezyQuote/tsdx
that referenced
this pull request
Dec 1, 2020
…#544) - if TSDX were installed directly from git, the `prepare` script would for some reason fail on these events - but they wouldn't error when run internally - when Rollup was upgraded, then they started erroring - also remove the unnecessary await in front of watch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if TSDX were installed directly from git, the
preparescript wouldfor some reason fail on these events
also remove the unnecessary await in front of watch
So this fixes, partially, #512 's issue with the
preparescript erroring out.The event type issues might be related to
@types/nodechanges like mentioned in #542, but idk, I didn't investigate remotely.Also supersedes #295 and #317, which were probably failing due to the old missing
.d.tserrors that were fixed with #504