Automated nightly rustfmt (2024-08-11)#1
Closed
github-actions[bot] wants to merge 0 commit intomasterfrom
Closed
Conversation
582192c to
5d8f4b2
Compare
jaoleal
added a commit
that referenced
this pull request
Oct 1, 2024
We noticed the possibilities of invariants inside the bip32 module. This commit Wants to cover all possible invariants of the bip32 indexes changing the enums with value to newtypes that only could be instantiated from its functionalities and constructors, especially while dealing with hardened indexes. Hardened indexes automatically defines its index while being casted, becoming infalibble to cast a Hardened index from a u32 value and the inner value is arbitrarily exposed with the accordingly value conversion, sucessfully covering cases with and without hardening notation. Naming changed, while dealing with key indexes we replaced the keyword and concept to "index" instead of number to better represent its unique function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated nightly
rustfmtchanges by create-pull-request GitHub action