Skip to content

feat: add @rspack/core as an optional peer dependency#1829

Merged
alexander-akait merged 1 commit intojantimon:mainfrom
chenjiahan:add_rspack_peer_dependency_1108
Dec 19, 2023
Merged

feat: add @rspack/core as an optional peer dependency#1829
alexander-akait merged 1 commit intojantimon:mainfrom
chenjiahan:add_rspack_peer_dependency_1108

Conversation

@chenjiahan
Copy link
Copy Markdown
Contributor

Background

Rspack is a fast Rust-based web bundler and it is compatible with the architecture and ecosystem of webpack.

The html-webpack-plugin can be used with Rspack, but users will get a peer dependency warning:

 WARN  Issues with peer dependencies found
.
 └─┬ html-webpack-plugin 5.5.3
    └── ✕ missing peer webpack@^5.20.0

Description

This PR adds @rspack/core as an optional peer dependency, and make webpack as an optional peer dependency too.

Related issues

@alexander-akait alexander-akait merged commit 56ff3ae into jantimon:main Dec 19, 2023
@chenjiahan chenjiahan deleted the add_rspack_peer_dependency_1108 branch December 19, 2023 14:31
@chenjiahan
Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants