Skip to content
This repository was archived by the owner on Jul 4, 2025. It is now read-only.

.tar.gz PowerShell issues fix.#373

Merged
hiro-v merged 5 commits into
janhq:mainfrom
MauroDruwel:main
Feb 19, 2024
Merged

.tar.gz PowerShell issues fix.#373
hiro-v merged 5 commits into
janhq:mainfrom
MauroDruwel:main

Conversation

@MauroDruwel

@MauroDruwel MauroDruwel commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Pull Request: Update install.bat for Compatibility with .tar.gz Extension in PowerShell

Overview

This pull request addresses a compatibility issue with the .tar.gz extension in PowerShell. It incorporates the fix from issue #234 in a more streamlined manner.

Details

The install.bat file has been updated to prevent compatibility issues with the .tar.gz extension when using PowerShell. This change enhances the user experience by preventing potential errors during the installation process.

Conclusion

This pull request provides a necessary update to the install.bat file, improving compatibility with PowerShell.

@MauroDruwel
Update install.bat
fa75643 
Update install.bat so there isn't a compatibility issue with the .tar.gz extension in powershell.
@hiro-v hiro-v requested a review from hiento09 January 24, 2024 02:21
@hiro-v hiro-v assigned hiro-v and MauroDruwel and unassigned hiro-v Jan 24, 2024
@hiro-v hiro-v added the type: bug Something isn't working label Jan 24, 2024
@tikikun tikikun requested a review from hiro-v January 30, 2024 01:03
@hiro-v

hiro-v commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Thank you for the contribution @MauroDruwel

However, I have tried to run the new install.bat file but cannot call nitro directly from the terminal (powershell and cmd).
Could you have a look as well.

The part for mkdir and tar is good

@MauroDruwel

MauroDruwel commented Jan 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Yeah I will check that! My pull request was just to fix this issue:
image
But I now see that I can't call nitro directly from the terminal. But I also couldn't with the old install.bat XD

Thank you for the contribution @MauroDruwel

However, I have tried to run the new install.bat file but cannot call nitro directly from the terminal (powershell and cmd). Could you have a look as well.

The part for mkdir and tar is good

@hiro-v

hiro-v commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

I see, for the changed part it's okay

@MauroDruwel

MauroDruwel commented Feb 3, 2024

Copy link
Copy Markdown
Contributor Author

Hi @hiro-v, I think I fixed it :) Atleast, it works on my pc. Could you try it? The problem was that the extracting was not saving the files in the %AppData%\nitro folder. But now it works :)

@hiro-v hiro-v removed their request for review February 11, 2024 05:48
hiento09
hiento09 approved these changes Feb 19, 2024
View reviewed changes

@hiento09 hiento09 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
works on my end!

@hiro-v hiro-v merged commit 2cb0900 into janhq:main Feb 19, 2024
@hiro-v hiro-v mentioned this pull request Feb 19, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@hiento09 hiento09 hiento09 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@MauroDruwel MauroDruwel

Labels

type: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MauroDruwel @hiro-v @hiento09