Merged
Conversation
`caml/signals.h` is not public API; it does not include `caml/config.h` and so it will not include `signal.h` because it does not know about `POSIX_SIGNAL`. This issue is visible on musl as "unknown type sigset_t". Signed-off-by: Etienne Millon <me@emillon.org>
8 tasks
dkalinichenko-js
pushed a commit
to dkalinichenko-js/opam-repository
that referenced
this pull request
Nov 12, 2024
CHANGES: - Support older GCC like 4.8.5 (janestreet/spawn#59) - Fix spawning processes on Windows when environment contains non-ascii characters (janestreet/spawn#58) - Skip calls to pthread_cancelstate on android, as its not available (janestreet/spawn#52) - Fix compatibility with systems that do not define `PIPE_BUF`. Use `_POSIX_PIPE_BUF` as a fallback. (janestreet/spawn#49) - [haiku] Fix compilation on Haiku OS. The header sys/syscalls.h isn't available, neither is pipe2() - Allow setting the sigprocmask for spawned processes (janestreet/spawn#32)
dkalinichenko-js
pushed a commit
to dkalinichenko-js/opam-repository
that referenced
this pull request
Nov 12, 2024
CHANGES: - Support older GCC like 4.8.5 (janestreet/spawn#59) - Fix spawning processes on Windows when environment contains non-ascii characters (janestreet/spawn#58) - Skip calls to pthread_cancelstate on android, as its not available (janestreet/spawn#52) - Fix compatibility with systems that do not define `PIPE_BUF`. Use `_POSIX_PIPE_BUF` as a fallback. (janestreet/spawn#49) - [haiku] Fix compilation on Haiku OS. The header sys/syscalls.h isn't available, neither is pipe2() - Allow setting the sigprocmask for spawned processes (janestreet/spawn#32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caml/signals.his not public API; it does not includecaml/config.hand so it will not includesignal.hbecause it does not know aboutPOSIX_SIGNAL. This issue is visible on musl as "unknown typesigset_t".