Skip to content

Bugfix/816 jamulus 2723 self-labelled checkboxes #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 2 commits into from
Jul 1, 2023
Merged

Bugfix/816 jamulus 2723 self-labelled checkboxes #931

ann0see merged 2 commits into from
Jul 1, 2023

Conversation

@pljones
Copy link
Contributor

@pljones pljones commented Jun 25, 2023 •
edited
Loading

Short description of changes
Update Jamulus manual for "self-labelled checkboxes" change, jamulussoftware/jamulus#2723.

Context: Fixes an issue? Related issues
Fixes: 816
See jamulussoftware/jamulus#2723 and jamulussoftware/jamulus#2996 for more details.

Status of this Pull Request
Work in progress, raised to create a tarball so I can get the latest state for testing.

What is missing until this pull request can be merged?

  • I need to add the server screenshots. (These appear to have been removed from the wiki.)
  • I need to look through the wiki text for references.
  • I need to check whether there are any other screenshots needing to be updated.
  • Then I'll move the PR out of draft so it'll be ready for review.

Does this need translation?
YES

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@pljones pljones added this to the Release 3.10.0 milestone Jun 25, 2023
@pljones pljones linked an issue Jun 25, 2023 that may be closed by this pull request
Checkbox controls should be "self-labelling" #816
Closed
@pljones pljones force-pushed the bugfix/816-jamulus-2723-self-label-checkboxes branch from c9bf34a to e7d8c67 Compare June 25, 2023 12:01
@pljones pljones force-pushed the bugfix/816-jamulus-2723-self-label-checkboxes branch from 69caac1 to a0d8a35 Compare June 25, 2023 13:24
@pljones
Copy link
Contributor Author

pljones commented Jun 25, 2023

I'm pushing my changes to http://jamuluswebsite.drealm.info/wiki/Software-Manual for easier review.

@pljones pljones self-assigned this Jun 25, 2023
@pljones pljones mentioned this pull request Jun 25, 2023
Closed
ann0see
ann0see reviewed Jun 25, 2023
View reviewed changes
ann0see
ann0see approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's ok.

@ann0see
Copy link
Member

ann0see commented Jul 1, 2023

Merging this now.

@ann0see ann0see merged commit 7a2a226 into jamulussoftware:next-release Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ann0see ann0see ann0see approved these changes

Assignees

@pljones pljones

Labels

None yet

Projects

Tracking
Status: Done

Milestone

Release 3.10.0

Development

Successfully merging this pull request may close these issues.

Checkbox controls should be "self-labelling"

2 participants

@pljones @ann0see