UI: Make checkboxes self-labelling #2847
Conversation
|
Website documentation is covered in jamulussoftware/jamuluswebsite#816 |
|
This seems to change much more than just the self-labeling checkboxes and makes the My Profile tab look strange due to the misaligned dropdown boxes on macOS
|
Yes, as noted in the issue. Is there an unrelated bug in MacOS, then? |
As it only shows up on this PR, I do think it's related. |
If it only shows on MacOS, it's unrelated. |
|
It could be a Qt6 issue then. |
|
No. It seems to be the same on the legacy build. |
Thanks for checking. I know we've had some Qt issues on MacOS (Qt5 and Qt6)... It's strange that Alias is different from Stadt - they're the same field type. I'll check there's nothing obviously different... |
6b5a335 to
e7d18e8
Compare
|
OK, I've now manually edited the clientsettingsbase.ui file to make the two input fields the same (copying the properties from the City/State to the Alias/Name). Can you take a look (once the artifact is there) to see if it's okay? (It looks the same in Linux.) |
|
No. Still the same
I think you should revert to the old box layout. |
|
Hold on... is that just the field highlighting? Tab onto the audio alerts field and do another screenshot, could you? |
hoffie
left a comment
There was a problem hiding this comment.
Do we really want to target 3.9.1 with this?
- As commented in-line, this will break some existing translated strings unless the PR manually fixes them up or we involve translators again.
- Having to update screenshots would also imply to call in translators for updated website screenshots, I guess?
src/clientsettingsdlgbase.ui
Outdated
| <enum>QSizePolicy::Expanding</enum> | ||
| </property> | ||
| <property name="sizeHint" stdset="0"> | ||
| <size> | ||
| <width>20</width> | ||
| <height>13</height> | ||
| <height>10</height> |
There was a problem hiding this comment.
These changes appear to be layout-relevant? Could they be the reason for the observed changes?
There was a problem hiding this comment.
I'm thinking <enum>QSizePolicy::Expanding</enum> could be the cause... Not sure why I missed your comment.
|
I'm happy enough to move this to 3.10.0. |
e7d18e8 to
ad7f1a1
Compare
|
Just to "zoom in" on the poor alignment: The MacOS fields are failing to follow the direction to fill the space given to them and align. |
f320f0e to
fb86776
Compare
|
Will test it in the following days (hopefully) |
|
Post when you're ready and then I'll make sure there are builds for all the branches. |
fb86776 to
b0fd9da
Compare
|
Should be good tonight (or tomorrow evening) |
|
Ok. It seems as if only 2 is good. |
|
I do wonder why grid layout doesn't work on the Mac... It does explain why it's not in use. |
|
Maybe some Qt bug… |
55b00b3 to
29653eb
Compare
6eaf359 to
6d226e4
Compare
d867181 to
e5bbeee
Compare
|
OK, found a couple of potentially relevant diffs from this version to "v2". @ann0see, once the build is clean, can you give it a try? I'll get the v2 and v3 done again, anyway. Edit Hm. Not sure what's happened but the source pre-v3 doesn't look like I'd remembered... v3 looks and acts as I'd expect, the earlier ones don't. |
95c288e to
5e5eefb
Compare
|
Sorry. I must have missed this. Will do the Test |
|
The asset from this PR donesn't seem ok. |
5e5eefb to
26a547a
Compare
|
NB this remains work in progress |
|
@pljones Can I test this again? |
Short description of changes
UI/UX issue #2723 requests that all check boxes be made "self-labelling". This makes the change to the relevant forms.
CHANGELOG: Make checkboxes self-labelling
Context: Fixes an issue?
Fixes: #2723
Does this change need documentation? What needs to be documented and how?
Yes, User Manual and Server Manual screen shot updates are needed. This affects translations.
Status of this Pull Request
Needs review.
What is missing until this pull request can be merged?
Needs review.
Checklist