Skip to content

Autobuild: Mac: Build with Qt 6.3.1 #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ann0see merged 1 commit into from
Jun 28, 2022
Merged

Autobuild: Mac: Build with Qt 6.3.1 #2672

ann0see merged 1 commit into from
Jun 28, 2022

Conversation

@ann0see
Copy link
Member

@ann0see ann0see commented Jun 24, 2022 •
edited
Loading

Short description of changes

This will start building with the latest version of macOS on the latest available SDK.
Related to: #2300

CHANGELOG: Build: macOS will now be built with Qt 6.3.1 for better support of modern versions of macOS. Users of macOS 10.14 or earlier must from now use the legacy build or compile from source.

Context: Fixes an issue?

Mostly GUI related issues, but it has the potential of fixing a few macOS related issues as mentioned in #2300

Does this change need documentation? What needs to be documented and how?

Yes. We need to tell macOS users that they might need to use the legacy version.

Status of this Pull Request

Final test on macOS. Will do as soon as the build is finished.
I used the latest SDK, but we can also use SDK 11 with Xcode 12 if that adds more compatibility

What is missing until this pull request can be merged?

Review and test. @emlynmac could you please test the artifacts?

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see
Autobuild: Mac: Build with Qt 6.3.1
d072103 
This will start building with the latest version of macOS on the latest available SDK.
Related to: jamulussoftware#2300
@ann0see ann0see added this to the Release 3.9.0 milestone Jun 24, 2022
@ann0see ann0see requested a review from hoffie June 24, 2022 19:35
@ann0see ann0see self-assigned this Jun 24, 2022
@ann0see
Copy link
Member Author

ann0see commented Jun 24, 2022 •
edited
Loading

macOS Catalina client and server work. Sound is ok (quicly tested over WiFi). GUI seems to be ok too. MacOS Monteray on a VM seems to work too (didn't test sound, but since it works on Catalina, it should be OK). As expected, the country and language are copied from a Qt 5.15.2 build.

@ann0see ann0see requested a review from pljones June 24, 2022 20:53
@pljones pljones mentioned this pull request Jun 25, 2022
Merged
14 tasks
@hoffie hoffie added the needs documentation PRs requiring documentation changes or additions label Jun 27, 2022
@hoffie
Copy link
Member

hoffie commented Jun 27, 2022

As expected, the country and language are copied from a Qt 5.15.2 build.

@ann0see, you mean that language settings work the same as after any other Jamulus update and there's no need for manual intervention, right?

@emlynmac
Copy link
Contributor

emlynmac commented Jun 27, 2022

@ann0see I've taken your branch and pushed to my repo to test the full auto build with signing.

@hoffie hoffie mentioned this pull request Jun 27, 2022
Closed
6 tasks
@ann0see
Copy link
Member Author

ann0see commented Jun 27, 2022

You mean that language settings work the same as after any other Jamulus update and there's no need for manual intervention, right?

Yes.

@emlynmac
Copy link
Contributor

emlynmac commented Jun 27, 2022

Signed build available here: https://github.com/emlynmac/jamulus/suites/7114281518/artifacts/282026065

@emlynmac
Copy link
Contributor

emlynmac commented Jun 27, 2022 •
edited
Loading

@ann0see Build works for me in Monterey

@ann0see
Copy link
Member Author

ann0see commented Jun 27, 2022

Just tested the signed build on a VM and it installed ok. So everything seems work as expected?

pljones
pljones approved these changes Jun 28, 2022
View reviewed changes
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on @emlynmac's sign off. Thanks!

@ann0see
Copy link
Member Author

ann0see commented Jun 28, 2022

Ok. Fingers crossed...

@ann0see ann0see merged commit 1c7b0a3 into jamulussoftware:master Jun 28, 2022
@ann0see ann0see deleted the feature/compileQt6mac branch June 28, 2022 19:01
@hoffie hoffie mentioned this pull request Jun 28, 2022
Merged
5 tasks
@hoffie
Copy link
Member

hoffie commented Jun 29, 2022

CI now logs a lack of aqt support for this version. I guess it's just cosmetical, but mentioning here anyway.

@hoffie hoffie mentioned this pull request Jun 29, 2022
Closed
ann0see added a commit to jamulussoftware/jamuluswebsite that referenced this pull request Jul 4, 2022
@ann0see
Document need of legacy build for more versions
e13d875 
Related to: jamulussoftware/jamulus#2672
@ann0see
Copy link
Member Author

ann0see commented Jul 4, 2022

I've now documented that the legacy version now should be used on Mojave or earlier: jamulussoftware/jamuluswebsite@e13d875

@pljones
Copy link
Collaborator

pljones commented Jul 4, 2022

I've now documented that the legacy version now should be used on Mojave or earlier: jamulussoftware/jamuluswebsite@e13d875

Once that's merged, the "needs documentation" label here should be removed, right?

@ann0see
Copy link
Member Author

ann0see commented Jul 4, 2022

Yes, if we don't have anything else. Probably the release announcement needs it mentioned.

@pljones
Copy link
Collaborator

pljones commented Jul 4, 2022

Yes, if we don't have anything else. Probably the release announcement needs it mentioned.

Mmm, maybe we need a tracker for the 3.9.0 build-time changes for all platforms, just to keep it up to date for reference. It gets messy putting it in the "Prepare Release" issue.

We should also have some way (maybe the same issue) for tracking specific changes we want to highlight in 3.9.0 (e.g. newly supported platforms and main features) -- basically, I guess, a draft of the release issue...

I don't know how best to do that - start it as an issue and then, when we release, move it to discussions?

@ann0see
Copy link
Member Author

ann0see commented Jul 8, 2022

Probably yes? I'll remove the needs documentation tag.

@ann0see ann0see removed the needs documentation PRs requiring documentation changes or additions label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoffie hoffie hoffie approved these changes

@pljones pljones pljones approved these changes

Assignees

@ann0see ann0see

Labels

None yet

Projects

None yet

Milestone

Release 3.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ann0see @hoffie @emlynmac @pljones