Audiomixerboard: Fix extra blank line when musician name length % iBreakPos == 0 #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
approved these changes
Mar 23, 2022
Collaborator
pljones
left a comment
There was a problem hiding this comment.
Might be complicated but it makes sense.
hoffie
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Fix a bug where a blank line is shown after some client’s name in the mixer board when their name’s length is divisible by
iBreakPos(which is 8 or 4).CHANGELOG: Client: Fix a bug where a blank line is shown after some client’s name in the mixer board in some conditions.
Context: Fixes an issue?
There is a regression introduced in Jamulus 3.8.2 by #1994 / #1993 (which fixes #1451) causing some musician’s name to have an extra blank line at the end.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Working fix
What is missing until this pull request can be merged?
N/A
Checklist