Autobuild: Fail if build artifact_1 is missing #2501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the job and release upload actions simply chose not to run when there's no artifact_1. However, all jobs should have at least one artifact, so this commit makes those steps fail in order to make potential errors visible instead of failing silently (all green, but missing artifact in job or release). Fixes jamulussoftware#2500
pljones
approved these changes
Mar 13, 2022
ann0see
approved these changes
Mar 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the job and release upload actions simply chose not to run when there's no artifact_1. However, all jobs should have at least one artifact, so this commit makes those steps fail in order to make potential errors visible instead of failing silently (all green, but missing artifact in job or release).
Short description of changes
CHANGELOG: Autobuild: Improved failure detection
Context: Fixes an issue?
Fixes #2500.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Checklist