Autobuild: Refactor and add dependency pinning #2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for using 'sh' instead of invoking the scripts directly seems to have been that the exec bit on the *prepare*.sh files had been missing. 408b985 fixed this already. Using bash consistently avoids unexpected issues due to usage of bash best-practices in non-bash environments. All those scripts run on Ubuntu or Mac where bash is available, so there's no need to artificially limit the usable language features.
The Android autobuild scripts contained a whole directory of archived code. The name suggests that it is unused. The repository does not contain any references to this directory either. Therefore remove it. Furthermore, the actively used scripts contained commented out code from the apparent conversion from a Dockerfile to bash scripts. It also contained references to older versions. This commit removes those instances of disabled code. Should we ever need it again, git has all the history.
Cleaning up unnecessary files such as the apt cache is important when building docker images. When running on Github Actions we shouldn't care about it as the whole runtime environment is destroyed more efficiently after each run. `apt` usage can also be condensed into a single call to reduce the (likely very minimal) startup overhead.
This was referenced Feb 5, 2022
ann0see
reviewed
Feb 5, 2022
ef6cd92 to
fd970e8
Compare
pljones
reviewed
Feb 5, 2022
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
Feb 5, 2022
fd970e8 to
e73a4de
Compare
pljones
approved these changes
Feb 5, 2022
Collaborator
|
Oh
|
This refactors several autobuild scripts to avoid repeated hardcoding of versions or paths.
This ensures that we always install specific versions of aqt and JACK. This helps with build reproducibility. It's also a requirement to be able to cache parts of the build environment.
e73a4de to
1113213
Compare
Member
Author
Heh, reverted back to ../latest/ (but kept the other improvements). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
This PR refactors the autobuild logic and introduces version pinning of external dependencies:
Pinning has partly been implemented already (Qt, NSIS, ASIOSDK, Android Command Line Tools, Android NDK, Android SDK). In addition, this PR introduces version pinning for JACK and aqtinstaller.
Context: Fixes an issue?
This is the basis for #2284 (for 3.9.0). The goal is to merge this for 3.8.2.
Does this change need documentation? What needs to be documented and how?
CHANGELOG: Internal: Release build process has been refactored and uses pinned dependencies for better reproducibility now.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Checklist