-
Notifications
You must be signed in to change notification settings - Fork 238
Mac: Use latest Xcode version with SDK 10.15 support #2266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Needs to be rebased. |
1cb1ac3 to
8ebf539
Compare
Thanks for the pointer, done. |
|
I think the CI should be enough to verify it works? I have a VM on the latest version of macOS, so I assume I can only test the latest version of Xcode. |
|
I think the build artifact should be tested, mainly on rather old Mac versions. |
softins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build log looks ok, and the artifact running on my Mac (Mojave) seems to run ok too.
|
@softins did you also check your location in my profile is it still correct? Probably the following related to my recent Qt6 try, but for me, I was now in another country. |
ann0see
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm quite sure the problem was my Qt6 try, I'll approve this
Edit: ah, you meant my location (flag?) in my own profile (not yours!). No, I will check. |
|
Sorry if I was unclear: Did your profile information stay sane, i.e. are all your profile infos; especially the country value correctly copied from a previous install? |
|
Sorry. I Should have quoted "My profile". |
|
Yes, all looked fine, switching between this version, 3.8.2 and the one from #2421. No surprises. |
|
Ah, remember the ini file in the unsigned versions will be in a different place from the signed ones. But the unsigned ones will have found my old ini from a couple a versions ago, and it was still sane. |
|
Great. Thanks. So it was related to the Qt6 issue. |
|
Yes, most likely, as the country codes changed. |
Short description of changes
This PR updates the autobuild configuration to use Xcode 12.1.1 (from 11.7). 12.1.1 is the latest release with SDK 10.15 included. SDK 10.15 is the highest release supported by Qt5, which is why we should not update to any higher version right now.
This official page confirms that 12.1.x is (and probably will stay?) the last version to support SDK 10.15, which we need for Qt5 compatibility: https://developer.apple.com/support/xcode/
This inofficial page lists 12.1.1 as the most-recent 12.1.x release: https://xcodereleases.com/
This is a continuation of #1794.
Context: Fixes an issue?
Nothing specific. The goal is to use the latest supported configuration.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
Checklist