Skip to content

Conversation

@hoffie
Copy link
Member

@hoffie hoffie commented Jan 23, 2022

Short description of changes

This PR updates the autobuild configuration to use Xcode 12.1.1 (from 11.7). 12.1.1 is the latest release with SDK 10.15 included. SDK 10.15 is the highest release supported by Qt5, which is why we should not update to any higher version right now.

This official page confirms that 12.1.x is (and probably will stay?) the last version to support SDK 10.15, which we need for Qt5 compatibility: https://developer.apple.com/support/xcode/
This inofficial page lists 12.1.1 as the most-recent 12.1.x release: https://xcodereleases.com/

This is a continuation of #1794.

Context: Fixes an issue?

Nothing specific. The goal is to use the latest supported configuration.

Does this change need documentation? What needs to be documented and how?

No.
Status of this Pull Request

Ready.

What is missing until this pull request can be merged?

  • Testing on Mac

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@hoffie hoffie added this to the Release 3.9.0 milestone Jan 23, 2022
@ann0see
Copy link
Member

ann0see commented Jan 23, 2022

@softins @emlynmac cound you please test this?

@ann0see
Copy link
Member

ann0see commented Feb 16, 2022

Needs to be rebased.

@hoffie
Copy link
Member Author

hoffie commented Feb 16, 2022

Needs to be rebased.

Thanks for the pointer, done.

@ann0see
Copy link
Member

ann0see commented Feb 16, 2022

I think the CI should be enough to verify it works? I have a VM on the latest version of macOS, so I assume I can only test the latest version of Xcode.

@hoffie
Copy link
Member Author

hoffie commented Feb 16, 2022

I think the build artifact should be tested, mainly on rather old Mac versions.
I'm not sure if we should require explicit testing or if any testing in the 3.9.0 beta/rc phase should be enough (I tend to say so).

@hoffie hoffie requested review from ann0see and softins February 20, 2022 23:37
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build log looks ok, and the artifact running on my Mac (Mojave) seems to run ok too.

@ann0see
Copy link
Member

ann0see commented Feb 21, 2022

@softins did you also check your location in my profile is it still correct?

Probably the following related to my recent Qt6 try, but for me, I was now in another country.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm quite sure the problem was my Qt6 try, I'll approve this

@softins
Copy link
Member

softins commented Feb 21, 2022

@softins did you also check your location in my profile is it still correct?

Sorry, I don't understand the question.

Edit: ah, you meant my location (flag?) in my own profile (not yours!). No, I will check.

@ann0see
Copy link
Member

ann0see commented Feb 21, 2022

Sorry if I was unclear: Did your profile information stay sane, i.e. are all your profile infos; especially the country value correctly copied from a previous install?

@ann0see
Copy link
Member

ann0see commented Feb 21, 2022

Sorry. I Should have quoted "My profile".

@softins
Copy link
Member

softins commented Feb 21, 2022

Yes, all looked fine, switching between this version, 3.8.2 and the one from #2421. No surprises.

@softins
Copy link
Member

softins commented Feb 21, 2022

Ah, remember the ini file in the unsigned versions will be in a different place from the signed ones. But the unsigned ones will have found my old ini from a couple a versions ago, and it was still sane.

@ann0see
Copy link
Member

ann0see commented Feb 21, 2022

Great. Thanks. So it was related to the Qt6 issue.

@ann0see ann0see merged commit 9ec578c into jamulussoftware:master Feb 21, 2022
@softins
Copy link
Member

softins commented Feb 21, 2022

Yes, most likely, as the country codes changed.

@softins softins mentioned this pull request Feb 21, 2022
5 tasks
@hoffie hoffie deleted the mac-xcode-12.1.1 branch March 19, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants