Mac autobuild: Update to Xcode 12 #1794
Conversation
|
Autobuild failed, Edit: Meh, it's just me being bad at properly using the method introduced in my commit before. Fixed and rebuilding now. |
08ef331 to
b467af2
Compare
|
I think what you have done is not enough. Xcode 12 only includes the 11.1 SDK by default. See my test run from 25 days ago at https://github.com/softins/jamulus/runs/2522272216 where I had added a line You would need to determine what commands are needed to load an additional older SDK before you can select it for building with. I started to look at that, but then side-stepped it by switching to Xcode 11. |
Yep, thanks, I noticed that some minutes ago and tried Xcode 12 which still ships 10.15. Currently fails in python scripts, looking into this now.
Yeah, I think this was and is the simplest solution. It's just that I'm hoping that code generated by newer Xcode might magically make our leak bugs go away... |
c66d866 to
7a329a2
Compare
|
If you are pinning the Xcode version to 12.0 (I think 12.1 would work too), in order to get the 10.15 SDK as default, I suspect you don't need the |
Let the autobuild default to Xcode 12 again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a slightly different approach to the already merged jamulussoftware#1655. We are limited to <= Xcode-12.1.1 though because we require SDK 10.15 which is not shipped on more recent versions anymore. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
Ah, right. Trying with 12.1.1 now.
Hrm, yep, can probably drop it. Will leave it in now. Do you know a way to use older SDKs with latest Xcode? All I've found was inofficial binary dumps, which I'd rather not use due to legal and security questions...? |
|
@emlynmac since you‘re a macOS specialist, could you have a look at this please? |
|
Is there a reason to use 12.1.1 instead of the current 12.4 Xcode? |
|
I doubt there’s a reason. Probably 12.1.1 was the latest version as this PR was opened? |
|
Maybe let's get as far up the chain as we can then? |
|
Yes, I think @dcorson-ticino-com worked on Qt 6 support, but I'm not sure how far he got. |
|
Let's have a look at the CI |
Yes, I have a Qt6 branch that compiles and works fine as far as I can see. |
@emlynmac Yes, see the comments further up (I've not been active over the weekend, so just picking up this conversation). Qt5 is only compatible with SDKs up to 10.15. If you use SDK 11, you get lots of warning messages from Qt about compatibility. Xcode 12.1.1 is apparently the last one that comes with SDK 10.15, which is why we pinned that one. We should continue to do so, unless someone can come up with a way to use SDK 10.15 with later versions of Xcode. |
|
@dcorson-ticino-com could you please open a PR on your work? Probably all the macOS issues are somehow related and Qt6 might solve them. @emlynmac @softins is it worth to move this forward for the next release or not? |
Certainly worth trying, but I'm not optimistic that Qt6 would be any better than Qt5 on Mac.
Maybe for 3.9.0, but certainly not for 3.8.1. |
Give me a couple of days, I'm no longer sure in what kind of state it is in. |
|
Ok. De-tagged. |
@emlynmac @dcorson-ticino-com @pljones not quite sure what to do with this. I'd rather open an issue to discuss the macOS problems... |
Tony has gone forward with this, but having compilation problems on git. I had it working OK under both QT5 and QT6 compiled locally. |
|
Ok. If we do remove the license note, we could get it to work. |
|
@softins @ann0see @emlynmac What's the current state of this PR? The initial PR did this, but it has been modified to update to 12.4, which is sub-optimal, I think: This official page confirms that 12.1.x is (and probably will stay?) the last version to support SDK 10.15, which we need for Qt5 compatibility: https://developer.apple.com/support/xcode/ As all the newly introduced logic wrt |
Let the autobuild default to latest xcode (= 12.x) again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions.
This is a different approach to the already merged #1655. This change has a (low) chance of fixing recent Mac issues on Big Sur
(#1643, #1791). At least, it makes us use the latest officially recommended setup.
This only touches the regular Mac build, not the legacy build.
Support matrix:
https://doc.qt.io/qt-5/macos.html
Variables:
https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk
Explanations:
https://doc.qt.io/qt-5/macos-deployment.html
This PR is just a blind test if it works like that at all (cannot try locally). If it does, it would be interesting to have affected users test this version.
cc @softins