Add action to select Xcode 11.7 for Qt5 compatibility on Mac #1655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
approved these changes
May 8, 2021
This was referenced May 11, 2021
Merged
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to latest xcode (= 12.x) again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to latest xcode (= 12.x) again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to latest xcode (= 12.x) again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to latest xcode (= 12.x) again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to latest xcode (= 12.x) again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to Xcode 12 again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. We are limited to <= Xcode-12.0 though because we require SDK 10.15 which is not shipped on more recent versions anymore. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to Xcode 12 again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a different approach to the already merged jamulussoftware#1655. We are limited to <= Xcode-12.0 though because we require SDK 10.15 which is not shipped on more recent versions anymore. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
hoffie
added a commit
to hoffie/jamulus
that referenced
this pull request
May 31, 2021
Let the autobuild default to Xcode 12 again, but still ensure that we limit SDK support to 10.15 due to lack of Qt-wise support for newer versions. This is a slightly different approach to the already merged jamulussoftware#1655. We are limited to <= Xcode-12.1.1 though because we require SDK 10.15 which is not shipped on more recent versions anymore. This change has a (low) chance of fixing recent Mac issues on Big Sur (jamulussoftware#1643, jamulussoftware#1791). At least, it makes us use the latest officially recommended setup. This only touches the regular Mac build, not the legacy build. Support matrix: https://doc.qt.io/qt-5/macos.html Variables: https://doc.qt.io/qt-5/qmake-variable-reference.html#qmake-mac-sdk Explanations: https://doc.qt.io/qt-5/macos-deployment.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing a build for Mac with Qt 5.15.2, the following warning was received:
This is because the default macOS build environment on Github is now using Xcode 12, which by default uses the 11.1 SDK.
Although Qt 5.9.9 does not give this warning, it seems likely that is because it just doesn't check, and it would seem reasonable to conclude that any potential incompatibility between Qt 5.15.2 and the 11.1 SDK would be even more the case with Qt 5.9.9.
This PR uses the action from https://github.com/marketplace/actions/setup-xcode-version to explicitly request Xcode 11.7, which by default uses the 10.15 SDK.