Merged
Conversation
mattbenyo
approved these changes
Nov 29, 2021
saljooki
approved these changes
Nov 29, 2021
jbradley89
approved these changes
Nov 29, 2021
persistence/PersistenceHandler.swift
Outdated
| let aftermathLaunchDir: URL | ||
|
|
||
| init() { | ||
| self.caseHandler = CaseHandler() |
Collaborator
There was a problem hiding this comment.
You'll have to bring the case handler in as an argument to the PersistenceHandle class because every module running from main will have to use the same caseHandler.
aftermath/main.swift
Outdated
| // Processes | ||
|
|
||
| // Persistence - DJ Beef Stew | ||
| let persistenceHandler = PersistenceHandle() |
Collaborator
There was a problem hiding this comment.
Log when this persistenceHandler starts and finishes
Contributor
Author
There was a problem hiding this comment.
via the aftermath.log?
| } catch { | ||
| print("Could not read \(atUrl.relativePath)") | ||
| print(error) | ||
| return plistDict |
Collaborator
There was a problem hiding this comment.
This line should be redundant (I know I gave you this code)
persistence/PersistenceHandler.swift
Outdated
| } | ||
|
|
||
| func captureLaunchData(urlLocations: [URL]) { | ||
| print("Capturing...") |
Collaborator
There was a problem hiding this comment.
Would be good to remove print statements. Use caseHandler.log() instead if needed.
Same applies when printing an error (I might need to clean this up in my code as well)
jbradley89
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.