Skip to content

Wrong version 53 package-info#389

Merged
lukasj merged 1 commit intojakartaee:masterfrom
jbescos:packageInfo
Apr 19, 2023
Merged

Wrong version 53 package-info#389
lukasj merged 1 commit intojakartaee:masterfrom
jbescos:packageInfo

Conversation

@jbescos
Copy link
Member

@jbescos jbescos commented Nov 24, 2022 •
edited
Loading

Original issue is here: eclipse-ee4j/parsson#73
PR for Parsson is: eclipse-ee4j/parsson#74

Fix can be verified in this way:

jsonp/api$ javap -verbose -classpath target/jakarta.json-api-2.1.1-SNAPSHOT.jar jakarta.json.package-info | grep version
  minor version: 0
  major version: 52

@jbescos
Wrong version 53 package-info
8d10c8a 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
lukasj
lukasj approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 713fc69 into jakartaee:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lukasj lukasj lukasj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbescos @lukasj