Skip to content

package-info.class files inside org.eclipse.parsson:jakarta.json are compiled with the wrong Java version #73#74

Merged
lukasj merged 1 commit intoeclipse-ee4j:masterfrom
jbescos:issue73
Apr 21, 2023
Merged

package-info.class files inside org.eclipse.parsson:jakarta.json are compiled with the wrong Java version #73#74
lukasj merged 1 commit intoeclipse-ee4j:masterfrom
jbescos:issue73

Conversation

@jbescos
Copy link
Member

@jbescos jbescos commented Nov 24, 2022

Relates to #73

To verify the fix:

$ mvn clean install
$ javap -verbose -classpath bundles/jakarta.json/target/jakarta.json-1.1.2-SNAPSHOT.jar jakarta.json.package-info | grep version
  minor version: 0
  major version: 52

Javadoc of packages are still there, you can verify it opening bundles/jakarta.json/target/site/apidocs/jakarta.json/jakarta/json/package-summary.html

…compiled with the wrong Java version eclipse-ee4j#73

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 7c9a82d into eclipse-ee4j:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants