Conversation
Merged
Member
|
@marchof Could you please verify my changes? |
Member
There was a problem hiding this comment.
Please rename to NoneController for consistency.
There are more cleanup opportunities:
- LoaclController should be renamed to FileContoller
- All xController classes should be renamed to xOutput
- package should be renamed to output
Member
Author
|
@Godin The new mode should also be listed in agent.html |
Member
|
@marchof I renamed NopController to NoneController, but will not do other cleanups, because for me they don't relate to this feature and should come via separate changeset all together. |
Member
Author
|
@Godin Perfect! I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the new Agent API #61 or MBean #62 is used, it might not be required to produce any other output. For this a new output mode 'none' should be provided.