Skip to content

Use rustls for reqwest#37

Merged
jackTabsCode merged 1 commit into
jackTabsCode:mainfrom
paradoxuum:build/rustls
May 4, 2024
Merged

Use rustls for reqwest#37
jackTabsCode merged 1 commit into
jackTabsCode:mainfrom
paradoxuum:build/rustls

Conversation

@paradoxuum

@paradoxuum paradoxuum commented May 3, 2024

Copy link
Copy Markdown
Contributor

This change enables the rustls-tls feature flag on the reqwest dependency. This allows it to use rustls in place of the openssl dependency, which should allow for further compatibility on different Linux distributions.

As far as I can tell, default-features must be disabled for this to work. From my testing, it doesn't seem to make a difference (i.e. cause an error) when it comes to building the project.

As it stands, the Linux binary for the latest release produces the following error on Ubuntu 22.04:
error while loading shared libraries: libssl.so.1.1: cannot open shared object file: No such file or directory
I suspect this is because the version of Ubuntu the binary was compiled on is different, so it expects a different version of OpenSSL.

This can also be solved by including the openssl dependency with the vendored feature enabled, but it seems like most Rust projects are using rustls now (including rbxcloud and aftman).

@jackTabsCode

Copy link
Copy Markdown
Owner

Yeah, this is probably a good idea. Thanks!

@jackTabsCode jackTabsCode merged commit d43b2df into jackTabsCode:main May 4, 2024
Zidiam pushed a commit to Zidiam/asphalt that referenced this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants