Revert back to use `serde_yaml` again by j178 · Pull Request #1112 · j178/prek

j178 · 2025-11-18T14:32:45Z

It's a good experiment anyway, I'll keep looking at serde-saphyr.

codecov · 2025-11-18T14:38:46Z

Codecov Report

❌ Patch coverage is 32.55814% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.97%. Comparing base (df5068a) to head (26e86aa).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/config.rs	17.14%	29 Missing ⚠️
src/yaml.rs	50.00%	22 Missing ⚠️
src/cli/auto_update.rs	0.00%	7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (df5068a) and HEAD (26e86aa). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (df5068a) HEAD (26e86aa)

2 1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1112       +/-   ##
===========================================
- Coverage   89.85%   26.97%   -62.88%     
===========================================
  Files          72       73        +1     
  Lines       13432    13471       +39     
===========================================
- Hits        12069     3634     -8435     
- Misses       1363     9837     +8474

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2025-11-18T14:41:09Z

📦 Cargo Bloat Comparison

Binary size change: -1.81% (16.6 MiB → 16.3 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.3%  97.4KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.0KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  41.3KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.5KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.4KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.7KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
 0.1%   0.3%  23.9KiB          hyper hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
40.1%  87.9%   6.5MiB                And 10242 smaller methods. Use -n N to show more.
45.7% 100.0%   7.4MiB                .text section size, the file size is 16.3MiB

Base Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.2%  97.7KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.7KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  41.3KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.8KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.5KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.3%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.1%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.1%   0.3%  25.3KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.6KiB           prek prek::cli::auto_update::auto_update::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
41.0%  88.3%   6.8MiB                And 10426 smaller methods. Use -n N to show more.
46.4% 100.0%   7.7MiB                .text section size, the file size is 16.6MiB

serde-saphyr has way better error message, and it is written in safe Rust. Previous try: #1087 Previous revert: #1106 and #1112 TODO: Replace serialize_yaml_scalar with serde-saphyr as well: https://github.com/j178/prek/blob/0a4be22599076b8c6273940b2760828b442c78f4/crates/prek/src/yaml.rs#L12-L13

j178 added the bug Something isn't working label Nov 18, 2025

Revert back to serde_yaml again

26e86aa

j178 force-pushed the serde-yaml-again branch from 215de30 to 26e86aa Compare November 18, 2025 14:35

j178 changed the title ~~Revert back to serde_yaml again~~ Revert back to use serde_yaml again Nov 18, 2025

j178 merged commit 683ad1f into master Nov 18, 2025
21 checks passed

j178 deleted the serde-yaml-again branch November 18, 2025 14:46

BrewTestBot mentioned this pull request Nov 18, 2025

prek 0.2.17 Homebrew/homebrew-core#254901

Merged

hugovk mentioned this pull request Nov 21, 2025

Enforce YAML formatting pypa/pip#13658

Closed

j178 mentioned this pull request Feb 1, 2026

Replace serde-yaml with serde-saphyr (again) #1520

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert back to use `serde_yaml` again#1112

Revert back to use `serde_yaml` again#1112
j178 merged 1 commit into
masterfrom
serde-yaml-again

j178 commented Nov 18, 2025 •

edited

Loading

Uh oh!

codecov Bot commented Nov 18, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 18, 2025

Head Branch Results

Base Branch Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

j178 commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Nov 18, 2025

📦 Cargo Bloat Comparison

Head Branch Results

Base Branch Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

j178 commented Nov 18, 2025 •

edited

Loading

codecov Bot commented Nov 18, 2025 •

edited

Loading