Skip to content

Don't leak temporary tuples in get_all()#36

Merged
iustin merged 2 commits intomasterfrom
issue35
Oct 9, 2022
Merged

Don't leak temporary tuples in get_all()#36
iustin merged 2 commits intomasterfrom
issue35

Conversation

@iustin
Copy link
Owner

@iustin iustin commented Oct 8, 2022

Issue #35 found a bug in the tuple-to-list addition error handling. This should fix it.

Copy link
Owner Author

@iustin iustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo…

@iustin
Copy link
Owner Author

iustin commented Oct 8, 2022

Sigh, how the heck do I trigger a CI run on this pull request…

@iustin iustin closed this Oct 9, 2022
@iustin iustin reopened this Oct 9, 2022
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 87.77% // Head: 87.77% // No change to project coverage 👍

Coverage data is based on head (4f8165a) compared to base (c3466e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files           1        1           
  Lines         499      499           
=======================================
  Hits          438      438           
  Misses         61       61           
Impacted Files Coverage Δ
xattr.c 87.77% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iustin iustin merged commit 5234c00 into master Oct 9, 2022
@iustin iustin deleted the issue35 branch October 9, 2022 21:07
iustin added a commit that referenced this pull request Oct 10, 2022
Together with the commit in #36, this should fix issue #35,
iustin added a commit that referenced this pull request Oct 10, 2022
Together with the commit in #36, this should fix #35.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant