Merged
Conversation
see the related mapping in format_positional().
Contributor
Author
|
@Freed-Wu @casperdcl please check. ^ |
ThomasWaldmann
commented
Nov 16, 2025
Collaborator
|
Thanks @ThomasWaldmann! I'd rather you put the second commit into a separate PR (with the added bonus that you can describe it in the PR body rather than writing a thesis in a commit comment, hah). |
87c2af9 to
5a81b8a
Compare
Contributor
Author
|
@casperdcl OK, moved the 2nd commit to a new PR, that is based on this one. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While searching for the root cause of #183, I also had a look into #93 and noticed a discrepancy.
See the related mapping in
format_positional(), line 515.I have no clue about zsh scripting or shell completions, but that looked suspicious.
Please review if my fix is actually correct.