Skip to content

misc zsh fixes#93

Merged
casperdcl merged 5 commits intoiterative:mainfrom
Freed-Wu:master
Nov 18, 2022
Merged

misc zsh fixes#93
casperdcl merged 5 commits intoiterative:mainfrom
Freed-Wu:master

Conversation

@Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Aug 28, 2022

@sourcery-ai

This comment was marked as off-topic.

Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops sorry wrong review)

@casperdcl casperdcl added the technical-debt Refactoring, linting & tidying label Oct 26, 2022
@casperdcl casperdcl self-assigned this Oct 26, 2022
@casperdcl casperdcl self-requested a review October 26, 2022 21:49
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Sorry for the delay.

@casperdcl casperdcl linked an issue Oct 26, 2022 that may be closed by this pull request
@casperdcl casperdcl added enhancement New feature or request shell-zsh and removed technical-debt Refactoring, linting & tidying labels Oct 26, 2022
@casperdcl casperdcl removed their assignment Oct 26, 2022
@casperdcl casperdcl added the external-request You asked, we did label Oct 26, 2022
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

@casperdcl
Copy link
Collaborator

@Freed-Wu Thanks! You wrote fixes #91 in a commit message, just clarifying you meant fixes #90, right?

@Freed-Wu
Copy link
Contributor Author

@Freed-Wu Thanks! You wrote fixes #91 in a commit message, just clarifying you meant fixes #90, right?

It also fix #91, which path completion failed in zsh. Because they are simple, I put them in one PR. If you like, I can split them to many PRs.

@casperdcl casperdcl linked an issue Nov 18, 2022 that may be closed by this pull request
@casperdcl casperdcl changed the title Fix #92 misc zsh fixes Nov 18, 2022
Freed-Wu and others added 5 commits November 18, 2022 22:08
Change `(- :)` to `(- : *)` for zsh
Add format_positional(opt) to all_commands and change zsh template to fix #91, and use argparse.{ONE_OR_MORE, ZERO_OR_MORE, REMAINDER} to replace raw string
Copy link
Collaborator

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@casperdcl casperdcl merged commit 6779de6 into iterative:main Nov 18, 2022
@casperdcl
Copy link
Collaborator

/tag v1.5.8 6779de6

@Freed-Wu Freed-Wu deleted the master branch November 19, 2022 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request external-request You asked, we did shell-zsh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] shtab's --print-completion should stop completion [bug] pathcomplete.py cannot complete file for zsh [feature] Support argparse.REMAINDER

2 participants