Skip to content

gdrive: download empty file #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efiop merged 1 commit into from
Sep 21, 2020
Merged

gdrive: download empty file #48

efiop merged 1 commit into from
Sep 21, 2020

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jul 26, 2020 •
edited
Loading

This was referenced Jul 28, 2020
Closed
Merged
@efiop
Copy link
Contributor Author

efiop commented Aug 9, 2020

Forgot about this PR, adding to the next sprint to sort it out.

@shcheklein shcheklein mentioned this pull request Sep 1, 2020
Closed
@efiop efiop force-pushed the fix-empty-file branch 11 times, most recently from 759218b to 99bb813 Compare September 8, 2020 02:23
efiop added a commit to treeverse/dvc that referenced this pull request Sep 8, 2020
@efiop
gdrive: add workaround for #4507
226322d 
Temporary workaround. Proper solution will be introduced in iterative/PyDrive2#48
@efiop efiop force-pushed the fix-empty-file branch 3 times, most recently from e153995 to 3c2be56 Compare September 8, 2020 03:13
efiop
efiop commented Sep 8, 2020
View reviewed changes
@efiop efiop force-pushed the fix-empty-file branch 3 times, most recently from 50ce41f to 7b478b7 Compare September 8, 2020 04:57
shcheklein
shcheklein reviewed Sep 8, 2020
View reviewed changes
@efiop efiop changed the title [WIP] gdrive: download empty file gdrive: download empty file Sep 8, 2020
@efiop efiop requested a review from shcheklein September 8, 2020 21:23
@efiop efiop removed the request for review from shcheklein September 8, 2020 21:33
@efiop efiop changed the title gdrive: download empty file [WIP] gdrive: download empty file Sep 8, 2020
shcheklein
shcheklein reviewed Sep 8, 2020
View reviewed changes
@efiop efiop changed the title [WIP] gdrive: download empty file gdrive: download empty file Sep 8, 2020
@efiop efiop changed the title gdrive: download empty file [WIP] gdrive: download empty file Sep 8, 2020
shcheklein
shcheklein reviewed Sep 9, 2020
View reviewed changes
@efiop efiop force-pushed the fix-empty-file branch 2 times, most recently from 7252e53 to 764bb63 Compare September 9, 2020 03:56
efiop
efiop commented Sep 9, 2020
View reviewed changes
@efiop efiop force-pushed the fix-empty-file branch 3 times, most recently from fa05e40 to ba4e05a Compare September 21, 2020 12:00
@efiop efiop changed the title [WIP] gdrive: download empty file gdrive: download empty file Sep 21, 2020
@efiop efiop requested a review from shcheklein September 21, 2020 12:19
@efiop efiop mentioned this pull request Sep 21, 2020
Closed
@efiop
Copy link
Contributor Author

efiop commented Sep 21, 2020

Created #59 for a proper solution once google guys fix it on their end.

@shcheklein
Copy link
Member

shcheklein commented Sep 21, 2020

thanks @efiop !

@efiop efiop merged commit 84a0b7a into master Sep 21, 2020
@efiop efiop deleted the fix-empty-file branch September 21, 2020 16:13
@efiop efiop mentioned this pull request Oct 21, 2020
Merged
efiop pushed a commit that referenced this pull request Oct 22, 2020
gdrive: remove empty file hack
5871dd9 
googleapis/google-api-python-client#1070 is now
merged, so we can get rid of our hack
#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efiop @shcheklein