fix: Move skills to the correct place#1097
Merged
Merged
Conversation
6d851a6 to
4417e13
Compare
59286ee to
c2e4385
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }, | ||
| schedule: { | ||
| cron: "0 */3 * * *", | ||
| runOnStart: false, |
There was a problem hiding this comment.
runOnStart changed from true to false during move
Medium Severity
The runOnStart value was changed from true (in the deleted iterate-customer-repo/pidnap.config.js) to false when moved here. With runOnStart: false, the monitoring agent will no longer execute immediately on startup — it will only fire on the cron schedule (every 3 hours). Since this PR is a structural move, the behavioral change looks accidental.
jonastemplestein
pushed a commit
that referenced
this pull request
Mar 3, 2026
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Low Risk** > Mostly documentation/config/template changes; the only behavior change is adding a new scheduled `trigger-monitor-agent` process in the default template, which could affect deployments if adopted. > > **Overview** > Moves/normalizes skill frontmatter under `.opencode/skills` (dropping the `publish: false` lines) and updates `architect-monitoring` wording to cover *sandbox & OS* monitoring. > > Removes the old `iterate-customer-repo` example config, and updates the default repo template to include a scheduled `trigger-monitor-agent` that posts a generic “Run monitoring mode” prompt via `scripts/trigger-monitor-agent.sh`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 59286ee. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
jonastemplestein
added a commit
that referenced
this pull request
Jun 10, 2026
…ir skills-registry generator (#1426) Sweep over agent skills plus a repair of the skills-publishing pipeline, which has been silently emitting an empty registry since the skills directory moved. ## Skill doc fixes - **error-pulse**: removed the `iterate tool subscribe-slack-thread` / `get-current-session-id` instructions — those tools were deleted with the daemon stack in #1341 and no equivalent thread-subscription mechanism exists today. The skill now states that escalation-thread follow-up is manual. - **architect**: - Required MCP access now points at the general Cloudflare API MCP server (`https://mcp.cloudflare.com/mcp`) instead of the product-specific observability endpoint that `.agents/skills/cloudflare-traces/SKILL.md` and `.agents/skills/debug-mcp-server/SKILL.md` explicitly forbid. - Dropped the `fly` CLI from diagnosis tool access and de-Fly'd the monitoring-mode section (kept as a pointer to `architect-monitoring`, which now covers OS/Cloudflare health monitoring; the Fly stack is removed). - Replaced the dead `iterate tool exec-ts 'await slack.chat.postMessage(...)'` snippet with a plain instruction to post the summary to `#monitoring`, noting the daemon tooling is gone. There is no documented programmatic Slack-posting CLI in the repo today, so the instruction stays mechanism-agnostic. - **architect-diagnose-performance**: removed the "Fly signals (machine health/usage)" input. - **playwriter-spec**: fixed the run command — `apps/os` has an `e2e` script (no `test:e2e`) and the suite reads `APP_CONFIG_BASE_URL` (not `OS_BASE_URL`). - **cloudflare-traces EXAMPLES.md**: the `os-preview-2` example now uses the dev/preview account id `376ef7ed81b0573f93524de763666c15` instead of the garple account. - **debug-os-worker**: `apps/os/src/entry.workerd.ts` no longer exists; replaced with `apps/os/src/worker.ts`. ## Registry pipeline repair - `apps/iterate-com/scripts/generate-skills-registry.mjs` still read `<repoRoot>/skills`, which was moved to `.opencode/skills` in #1097, and swallowed the ENOENT — so the published `.well-known/skills` registry has been empty ever since. The generator now reads `.opencode/skills` and fails loudly if the directory is missing. - Regenerated `apps/iterate-com/backend/generated/skills-registry.ts`; it now contains the two `publish: true` skills (`example-skill`, `playwriter-spec`). - `lint-staged.config.cjs` had the same stale `skills/**` glob, so the auto-regeneration hook never fired on skill changes; updated to `.opencode/skills/**`. - `.opencode/skills/AGENTS.md` updated to describe the fixed pipeline. - **example-skill** kept `publish: true` and got an honest description/body as a minimal registry smoke-test skill (see flags below). ## Checks - `pnpm install`, `pnpm format` (oxfmt), `pnpm lint`, `pnpm typecheck` — all green. - `node apps/iterate-com/scripts/generate-skills-registry.mjs` and `pnpm --dir apps/iterate-com skills:generate` — output contains both publish:true skills. - `pnpm --dir apps/iterate-com build` — builds successfully with the regenerated registry. ## Skipped - Nothing skipped; all nine items re-verified against the code and applied. Did not touch `.agents/skills/adding-a-new-durable-object-mixin/` or `.agents/skills/drizzle-migrations/` (owned by other PRs). ## Flags for reviewers - **example-skill judgment call**: I kept `publish: true` and rewrote it as an explicit registry smoke-test skill rather than unpublishing it — having one always-published skill gives the `.well-known/skills` endpoint a guaranteed non-empty payload to check against. Flip to `publish: false` if you'd rather not ship it. - **Architect Slack reporting is now mechanism-agnostic**: with the daemon tooling gone I found no replacement programmatic Slack-posting path in the repo, so the skill just says to post to `#monitoring` with whatever access the runtime has. If a real mechanism exists (or gets added), the skill should name it. - Merging this changes what `iterate.com/.well-known/skills` serves on next iterate-com deploy: from an empty list to `example-skill` + `playwriter-spec`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation and generated registry only; no runtime app logic, though iterate-com deploy will change the public skills list from empty to two published skills. > > **Overview** > Repairs the **skills publishing pipeline** after skills moved to `.opencode/skills`: the generator and `lint-staged` no longer point at the old `skills/` path or silently emit an empty registry—it reads `.opencode/skills`, errors if that folder is missing, and the checked-in `skills-registry.ts` now lists **`example-skill`** and **`playwriter-spec`**. **`.well-known/skills`** will serve real content on the next iterate-com deploy. > > Agent skill docs are updated to match the current stack: removed **Fly** / **daemon** references (`iterate tool exec-ts`, `subscribe-slack-thread`), **architect** now requires the general **Cloudflare API MCP** and mechanism-agnostic Slack posting, **error-pulse** documents manual thread follow-up, and small fixes cover **playwriter-spec** e2e command/env, **debug-os-worker** entry at `worker.ts`, **cloudflare-traces** example account id, and **example-skill** as an explicit registry smoke test. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit bf50747. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
Low risk documentation/config churn: adjusts skill frontmatter and monitoring messaging, plus removes an example customer repo template, with minimal impact beyond how monitoring is scheduled/triggered in the default template.
Overview
Marks several
.opencode/skills/architect-*skills as non-public by removingpublish: falsefrom frontmatter, and updatesarchitect-monitoringcopy to target sandbox/OS monitoring rather than Fly-only wording.Removes the
iterate-customer-repoexample (README +pidnap.config.js) and updates the defaultrepo-templates/default/iterate.config.tsto add a scheduledtrigger-monitor-agentprocess (every 3 hours). The monitor trigger script’s prompt is also generalized from “Fly monitoring” to “monitoring mode”.Written by Cursor Bugbot for commit c2e4385. This will update automatically on new commits. Configure here.