Add "SDS + CertManager" test scenario to the perf tests suite#72
Merged
costinm merged 1 commit intoistio:masterfrom Feb 28, 2019
Merged
Add "SDS + CertManager" test scenario to the perf tests suite#72costinm merged 1 commit intoistio:masterfrom
costinm merged 1 commit intoistio:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
howardjohn
reviewed
Feb 25, 2019
| - "https://$(EXTERNAL_ADDR)/echo?size=1024" | ||
| env: | ||
| - name: EXTERNAL_ADDR | ||
| valueFrom: |
Member
There was a problem hiding this comment.
Why can't we just use value: {{ .Values.ingressDomain }} here?
Member
Author
There was a problem hiding this comment.
Yeah, you're right, this is copy-paste from "gateway-bouncer", we don't need all this ConfigMap manipulations in this scenario, as we have a real domain here. Pushed a fix.
* Refer to the README.md for details. * Similarly to the "gateway-bouncer" scenario this one attempts to maintain all the components isolated within a dedicated namespace. * Component definitions are currently hardcoded. This should be addressed once the new installer is ready. * Fixed the way restarts are being triggered for both this scenario and 'gateway-bouncer' -- patching 'annotations' instead of labels. * 'gateway-bouncer' bugfix related to the 'bounce' sequence. Minor fixes for the "SDS + CertManager" test scenario * Fortio Client no longer uses ConfigMap to pass the address. This was a copy-paste from "gateway-bouncer" scenario which isn't necessary here as we have a proper DNS name for the Ingress in this scenario. * Exposed Prometheus metrics port of the Ingress Gateway (same for the "gateway-bouncer" scenario). Fix "SDS + CertManager scenario" setup script * Added a graceful message in case GCloud SDK is not present in the PATH with a brief explanation of why this is necessary. Upgrade version of the CertManager used in the "SDS + CertManager" scenario to 0.6.2 * Tesing CertManager v0.6.2 before it lands into 1.1 release. * Certificate 'renewBefore' directive works fine with v0.6.2 -- removing the 'certrotator' periodic job.
costinm
approved these changes
Feb 28, 2019
therealmitchconnors
pushed a commit
to therealmitchconnors/tools
that referenced
this pull request
Mar 1, 2019
* Refer to the README.md for details. * Similarly to the "gateway-bouncer" scenario this one attempts to maintain all the components isolated within a dedicated namespace. * Component definitions are currently hardcoded. This should be addressed once the new installer is ready. * Fixed the way restarts are being triggered for both this scenario and 'gateway-bouncer' -- patching 'annotations' instead of labels. * 'gateway-bouncer' bugfix related to the 'bounce' sequence. Minor fixes for the "SDS + CertManager" test scenario * Fortio Client no longer uses ConfigMap to pass the address. This was a copy-paste from "gateway-bouncer" scenario which isn't necessary here as we have a proper DNS name for the Ingress in this scenario. * Exposed Prometheus metrics port of the Ingress Gateway (same for the "gateway-bouncer" scenario). Fix "SDS + CertManager scenario" setup script * Added a graceful message in case GCloud SDK is not present in the PATH with a brief explanation of why this is necessary. Upgrade version of the CertManager used in the "SDS + CertManager" scenario to 0.6.2 * Tesing CertManager v0.6.2 before it lands into 1.1 release. * Certificate 'renewBefore' directive works fine with v0.6.2 -- removing the 'certrotator' periodic job.
4 tasks
Shuanglu
pushed a commit
to Shuanglu/istio-tools
that referenced
this pull request
Jun 30, 2022
* Refer to the README.md for details. * Similarly to the "gateway-bouncer" scenario this one attempts to maintain all the components isolated within a dedicated namespace. * Component definitions are currently hardcoded. This should be addressed once the new installer is ready. * Fixed the way restarts are being triggered for both this scenario and 'gateway-bouncer' -- patching 'annotations' instead of labels. * 'gateway-bouncer' bugfix related to the 'bounce' sequence. Minor fixes for the "SDS + CertManager" test scenario * Fortio Client no longer uses ConfigMap to pass the address. This was a copy-paste from "gateway-bouncer" scenario which isn't necessary here as we have a proper DNS name for the Ingress in this scenario. * Exposed Prometheus metrics port of the Ingress Gateway (same for the "gateway-bouncer" scenario). Fix "SDS + CertManager scenario" setup script * Added a graceful message in case GCloud SDK is not present in the PATH with a brief explanation of why this is necessary. Upgrade version of the CertManager used in the "SDS + CertManager" scenario to 0.6.2 * Tesing CertManager v0.6.2 before it lands into 1.1 release. * Certificate 'renewBefore' directive works fine with v0.6.2 -- removing the 'certrotator' periodic job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to the README.md for details.
Similarly to the "gateway-bouncer" scenario this one attempts to
maintain all the components isolated within a dedicated namespace.
Component definitions are currently hardcoded. This should be
addressed once the new installer is ready.
Fixed the way restarts are being triggered for both this scenario
and 'gateway-bouncer' -- patching 'annotations' instead of labels.
'gateway-bouncer' bugfix related to the 'bounce' sequence.