Skip to content

Update setup.sh to new location for Istio CRDS#34

Merged
mandarjog merged 1 commit intoistio:masterfrom
therealmitchconnors:patch-1
Jan 11, 2019
Merged

Update setup.sh to new location for Istio CRDS#34
mandarjog merged 1 commit intoistio:masterfrom
therealmitchconnors:patch-1

Conversation

@therealmitchconnors
Copy link
Copy Markdown
Contributor

istio/istio#10562 moved CRD.yaml files from ./istio/templates to ./istio-init/files. This change works with both the old and new paths for backwards compatibility.

istio/istio#10562 moved CRD.yaml files from ./istio/templates to ./istio-init/files.  This change works with both the old and new paths for backwards compatibility.
@istio-testing
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog mandarjog self-requested a review January 11, 2019 19:14
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Contributor

@mandarjog: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandarjog mandarjog merged commit 274a995 into istio:master Jan 11, 2019
if [[ -f "${DIRNAME}/${release}/istio/templates/crds.yaml" ]];then
kubectl apply -f "${DIRNAME}/${release}/istio/templates/crds.yaml"
else
kubectl apply -f "${DIRNAME}/${release}/istio-init/files/"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing fi

Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
istio/istio#10562 moved CRD.yaml files from ./istio/templates to ./istio-init/files.  This change works with both the old and new paths for backwards compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants