Skip to content

Removing mounting kubeconfig for Mason#701

Merged
istio-merge-robot merged 2 commits intoistio:masterfrom
sebastienvas:prepro
Feb 21, 2018
Merged

Removing mounting kubeconfig for Mason#701
istio-merge-robot merged 2 commits intoistio:masterfrom
sebastienvas:prepro

Conversation

@sebastienvas
Copy link
Copy Markdown
Contributor

@sebastienvas sebastienvas commented Feb 20, 2018 •
edited
Loading

Required for istio/istio#3615

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 20, 2018
@sebastienvas sebastienvas mentioned this pull request Feb 20, 2018
Merged
@chxchx
Copy link
Copy Markdown
Contributor

chxchx commented Feb 20, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 20, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@googlebot
Copy link
Copy Markdown

googlebot commented Feb 21, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Feb 21, 2018
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

/lgtm cancel //PR changed after LGTM, removing LGTM. @chxchx @sebastienvas

@chxchx
Copy link
Copy Markdown
Contributor

chxchx commented Feb 21, 2018

/lgtm

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chxchx

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@chxchx chxchx added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Feb 21, 2018
@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link
Copy Markdown

istio-merge-robot commented Feb 21, 2018

Automatic merge from submit-queue.

@istio-merge-robot istio-merge-robot merged commit 0081bd4 into istio:master Feb 21, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Feb 21, 2018

@sebastienvas: I updated Prow config for you!

Details

In response to this:

Required for istio/istio#3615

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-merge-robot pushed a commit to istio/istio that referenced this pull request Feb 21, 2018
@sebastienvas @istio-merge-robot
Enabling cluster provisioning on no auth test (#3615)
286f816 
Automatic merge from submit-queue.

Enabling cluster provisioning on no auth test

Requires istio/test-infra#701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chxchx chxchx

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastienvas @chxchx @istio-merge-robot @googlebot @istio-testing